Push comments to work notes

elastic · Feb 2, 2021 · 5fb7113 · 5fb7113
1 parent 077bdb2
commit 5fb7113
Show file tree

Hide file tree

Showing 4 changed files with 86 additions and 3 deletions.
diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/api.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/api.ts
@@ -23,6 +23,7 @@ const pushToServiceHandler = async ({
   externalService,
   params,
   secrets,
+  commentFieldKey,
 }: PushToServiceApiHandlerArgs): Promise<PushToServiceResponse> => {
   const { comments } = params;
   let res: PushToServiceResponse;
@@ -51,7 +52,7 @@ const pushToServiceHandler = async ({
         incidentId: res.id,
         incident: {
           ...incident,
-          comments: currentComment.comment,
+          [commentFieldKey]: currentComment.comment,
         },
       });
       res.comments = [

diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/index.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/index.ts
@@ -95,7 +95,12 @@ export function getServiceNowSIRActionType(
       }),
       params: ExecutorParamsSchemaSIR,
     },
-    executor: curry(executor)({ logger, configurationUtilities, table: serviceNowSIRTable }),
+    executor: curry(executor)({
+      logger,
+      configurationUtilities,
+      table: serviceNowSIRTable,
+      commentFieldKey: 'work_notes',
+    }),
   };
 }
 
@@ -106,7 +111,13 @@ async function executor(
     logger,
     configurationUtilities,
     table,
-  }: { logger: Logger; configurationUtilities: ActionsConfigurationUtilities; table: string },
+    commentFieldKey = 'comments',
+  }: {
+    logger: Logger;
+    configurationUtilities: ActionsConfigurationUtilities;
+    table: string;
+    commentFieldKey?: string;
+  },
   execOptions: ActionTypeExecutorOptions<
     ServiceNowPublicConfigurationType,
     ServiceNowSecretConfigurationType,
@@ -146,6 +157,7 @@ async function executor(
       params: pushToServiceParams,
       secrets,
       logger,
+      commentFieldKey,
     });
 
     logger.debug(`response push to service for incident id: ${data.id}`);

diff --git a/x-pack/plugins/actions/server/builtin_action_types/servicenow/types.ts b/x-pack/plugins/actions/server/builtin_action_types/servicenow/types.ts
@@ -120,6 +120,7 @@ export interface PushToServiceApiHandlerArgs extends ExternalServiceApiHandlerAr
   params: PushToServiceApiParams;
   secrets: Record<string, unknown>;
   logger: Logger;
+  commentFieldKey: string;
 }
 
 export interface GetIncidentApiHandlerArgs extends ExternalServiceApiHandlerArgs {

diff --git a/x-pack/plugins/case/server/routes/api/cases/mock.ts b/x-pack/plugins/case/server/routes/api/cases/mock.ts
@@ -0,0 +1,69 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License;
+ * you may not use this file except in compliance with the Elastic License.
+ */
+import {
+  BasicParams,
+  CommentResponse,
+  CommentType,
+  ConnectorMappingsAttributes,
+} from '../../../../common/api';
+
+export const updateUser = {
+  updatedAt: '2020-03-13T08:34:53.450Z',
+  updatedBy: { full_name: 'Another User', username: 'another' },
+};
+
+const entity = {
+  createdAt: '2020-03-13T08:34:53.450Z',
+  createdBy: { full_name: 'Elastic User', username: 'elastic', email: 'elastic@elastic.co' },
+  updatedAt: null,
+  updatedBy: null,
+};
+
+export const comment: CommentResponse = {
+  id: 'mock-comment-1',
+  comment: 'Wow, good luck catching that bad meanie!',
+  type: CommentType.user as const,
+  created_at: '2019-11-25T21:55:00.177Z',
+  created_by: {
+    full_name: 'elastic',
+    email: 'testemail@elastic.co',
+    username: 'elastic',
+  },
+  pushed_at: null,
+  pushed_by: null,
+  updated_at: '2019-11-25T21:55:00.177Z',
+  updated_by: {
+    full_name: 'elastic',
+    email: 'testemail@elastic.co',
+    username: 'elastic',
+  },
+  version: 'WzEsMV0=',
+};
+
+export const defaultPipes = ['informationCreated'];
+export const basicParams: BasicParams = {
+  description: 'a description',
+  title: 'a title',
+  ...entity,
+};
+
+export const mappings: ConnectorMappingsAttributes[] = [
+  {
+    source: 'title',
+    target: 'short_description',
+    action_type: 'overwrite',
+  },
+  {
+    source: 'description',
+    target: 'description',
+    action_type: 'append',
+  },
+  {
+    source: 'comments',
+    target: 'comments',
+    action_type: 'append',
+  },
+];