removing memoizing order

elastic · Feb 19, 2021 · 673019b · 673019b
1 parent 8c6e429
commit 673019b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 16 deletions.
diff --git a/...lens/public/editor_frame_service/editor_frame/config_panel/draggable_dimension_button.tsx b/...lens/public/editor_frame_service/editor_frame/config_panel/draggable_dimension_button.tsx
@@ -107,13 +107,6 @@ export function DraggableDimensionButton({
     columnId,
   ]);
 
-  /* 2 to leave room for data panel and workspace, then go by layer index, then by group index */
-  const order = useMemo(() => [2, layerIndex, groupIndex, accessorIndex], [
-    layerIndex,
-    groupIndex,
-    accessorIndex,
-  ]);
-
   const handleOnDrop = React.useCallback(
     (droppedItem, selectedDropType) => onDrop(droppedItem, value, selectedDropType),
     [value, onDrop]
@@ -128,7 +121,7 @@ export function DraggableDimensionButton({
       <DragDrop
         getAdditionalClassesOnEnter={getAdditionalClassesOnEnter}
         getAdditionalClassesOnDroppable={getAdditionalClassesOnDroppable}
-        order={order}
+        order={[2, layerIndex, groupIndex, accessorIndex]}
         draggable
         dragType={isDraggedOperation(dragging) ? 'move' : 'copy'}
         dropType={dropType}

diff --git a/...ins/lens/public/editor_frame_service/editor_frame/config_panel/empty_dimension_button.tsx b/...ins/lens/public/editor_frame_service/editor_frame/config_panel/empty_dimension_button.tsx
@@ -85,13 +85,6 @@ export function EmptyDimensionButton({
     [dropType, newColumnId, group.groupId, layerId, group.groupLabel, itemIndex, nextLabel]
   );
 
-  /* 2 to leave room for data panel and workspace, then go by layer index, then by group index */
-  const order = useMemo(() => [2, layerIndex, groupIndex, itemIndex], [
-    layerIndex,
-    groupIndex,
-    itemIndex,
-  ]);
-
   const handleOnDrop = React.useCallback(
     (droppedItem, selectedDropType) => onDrop(droppedItem, value, selectedDropType),
     [value, onDrop]
@@ -102,7 +95,7 @@ export function EmptyDimensionButton({
       <DragDrop
         getAdditionalClassesOnDroppable={getAdditionalClassesOnDroppable}
         value={value}
-        order={order}
+        order={[2, layerIndex, groupIndex, itemIndex]}
         onDrop={handleOnDrop}
         dropType={dropType}
       >