Skip to content

Commit

Permalink
Migrated vislib tests to the NP (#70309)
Browse files Browse the repository at this point in the history 
* Migrated vislib tests to the NP

* fixed tests

* Fixed tests

* Fixed test
  • Loading branch information
@VladLasitsa
VladLasitsa authored Jul 9, 2020
1 parent 58cdbf0 commit 6a8fdaa
Show file tree
Hide file tree
Showing 18 changed files with 743 additions and 408 deletions.
2 changes: 1 addition & 1 deletion src/plugins/charts/public/services/colors/mock.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ const colors = new ColorsService();
colors.init(coreMock.createSetup().uiSettings);

export const colorsServiceMock: ColorsService = {
createColorLookupFunction: jest.fn(colors.createColorLookupFunction),
createColorLookupFunction: jest.fn(colors.createColorLookupFunction.bind(colors)),
} as any;
40 changes: 30 additions & 10 deletions ...ests__/vis_type_vislib/lib/chart_title.js → ...lib/public/vislib/lib/chart_title.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,15 @@

import d3 from 'd3';
import _ from 'lodash';
import expect from '@kbn/expect';
import {
setHTMLElementClientSizes,
setSVGElementGetBBox,
setSVGElementGetComputedTextLength,
} from '../../../../../test_utils/public';

import { ChartTitle } from '../../../../../../../plugins/vis_type_vislib/public/vislib/lib/chart_title';
import { VisConfig } from '../../../../../../../plugins/vis_type_vislib/public/vislib/lib/vis_config';
import { getMockUiState } from '../../../../../../../plugins/vis_type_vislib/public/fixtures/mocks';
import { ChartTitle } from './chart_title';
import { VisConfig } from './vis_config';
import { getMockUiState } from '../../fixtures/mocks';

describe('Vislib ChartTitle Class Test Suite', function () {
let mockUiState;
Expand Down Expand Up @@ -88,6 +92,16 @@ describe('Vislib ChartTitle Class Test Suite', function () {
yAxisLabel: 'Count',
};

let mockedHTMLElementClientSizes;
let mockedSVGElementGetBBox;
let mockedSVGElementGetComputedTextLength;

beforeAll(() => {
mockedHTMLElementClientSizes = setHTMLElementClientSizes(512, 512);
mockedSVGElementGetBBox = setSVGElementGetBBox(100);
mockedSVGElementGetComputedTextLength = setSVGElementGetComputedTextLength(100);
});

beforeEach(() => {
mockUiState = getMockUiState();
el = d3.select('body').append('div').attr('class', 'visWrapper').datum(data);
Expand All @@ -113,23 +127,29 @@ describe('Vislib ChartTitle Class Test Suite', function () {
el.remove();
});

afterAll(() => {
mockedHTMLElementClientSizes.mockRestore();
mockedSVGElementGetBBox.mockRestore();
mockedSVGElementGetComputedTextLength.mockRestore();
});

describe('render Method', function () {
beforeEach(function () {
chartTitle.render();
});

it('should append an svg to div', function () {
expect(el.select('.chart-title').selectAll('svg').length).to.be(1);
test('should append an svg to div', function () {
expect(el.select('.chart-title').selectAll('svg').length).toBe(1);
});

it('should append text', function () {
expect(!!el.select('.chart-title').selectAll('svg').selectAll('text')).to.be(true);
test('should append text', function () {
expect(!!el.select('.chart-title').selectAll('svg').selectAll('text')).toBe(true);
});
});

describe('draw Method', function () {
it('should be a function', function () {
expect(_.isFunction(chartTitle.draw())).to.be(true);
test('should be a function', function () {
expect(_.isFunction(chartTitle.draw())).toBe(true);
});
});
});
82 changes: 51 additions & 31 deletions ...__tests__/vis_type_vislib/lib/dispatch.js → ...vislib/public/vislib/lib/dispatch.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,13 +19,21 @@

import _ from 'lodash';
import d3 from 'd3';
import expect from '@kbn/expect';
import {
setHTMLElementClientSizes,
setSVGElementGetBBox,
setSVGElementGetComputedTextLength,
} from '../../../../../test_utils/public';

// Data
import data from '../../../../../../../plugins/vis_type_vislib/public/fixtures/mock_data/date_histogram/_series';
import data from '../../fixtures/mock_data/date_histogram/_series';

import { getMockUiState } from '../../../../../../../plugins/vis_type_vislib/public/fixtures/mocks';
import { getVis } from '../_vis_fixture';
import { getMockUiState } from '../../fixtures/mocks';
import { getVis } from '../visualizations/_vis_fixture';

let mockedHTMLElementClientSizes;
let mockedSVGElementGetBBox;
let mockedSVGElementGetComputedTextLength;

describe('Vislib Dispatch Class Test Suite', function () {
function destroyVis(vis) {
Expand All @@ -36,6 +44,18 @@ describe('Vislib Dispatch Class Test Suite', function () {
return d3.select(element).data(new Array(n)).enter().append(type);
}

beforeAll(() => {
mockedHTMLElementClientSizes = setHTMLElementClientSizes(512, 512);
mockedSVGElementGetBBox = setSVGElementGetBBox(100);
mockedSVGElementGetComputedTextLength = setSVGElementGetComputedTextLength(100);
});

afterAll(() => {
mockedHTMLElementClientSizes.mockRestore();
mockedSVGElementGetBBox.mockRestore();
mockedSVGElementGetComputedTextLength.mockRestore();
});

describe('', function () {
let vis;
let mockUiState;
Expand All @@ -50,13 +70,13 @@ describe('Vislib Dispatch Class Test Suite', function () {
destroyVis(vis);
});

it('implements on, off, emit methods', function () {
test('implements on, off, emit methods', function () {
const events = _.map(vis.handler.charts, 'events');
expect(events.length).to.be.above(0);
expect(events.length).toBeGreaterThan(0);
events.forEach(function (dispatch) {
expect(dispatch).to.have.property('on');
expect(dispatch).to.have.property('off');
expect(dispatch).to.have.property('emit');
expect(dispatch).toHaveProperty('on');
expect(dispatch).toHaveProperty('off');
expect(dispatch).toHaveProperty('emit');
});
});
});
Expand All @@ -77,15 +97,15 @@ describe('Vislib Dispatch Class Test Suite', function () {
});

describe('addEvent method', function () {
it('returns a function that binds the passed event to a selection', function () {
test('returns a function that binds the passed event to a selection', function () {
const chart = _.first(vis.handler.charts);
const apply = chart.events.addEvent('event', _.noop);
expect(apply).to.be.a('function');
expect(apply).toBeInstanceOf(Function);

const els = getEls(vis.element, 3, 'div');
apply(els);
els.each(function () {
expect(d3.select(this).on('event')).to.be(_.noop);
expect(d3.select(this).on('event')).toBe(_.noop);
});
});
});
Expand All @@ -94,21 +114,21 @@ describe('Vislib Dispatch Class Test Suite', function () {
// checking that they return function which bind the events expected
function checkBoundAddMethod(name, event) {
describe(name + ' method', function () {
it('should be a function', function () {
test('should be a function', function () {
vis.handler.charts.forEach(function (chart) {
expect(chart.events[name]).to.be.a('function');
expect(chart.events[name]).toBeInstanceOf(Function);
});
});

it('returns a function that binds ' + event + ' events to a selection', function () {
test('returns a function that binds ' + event + ' events to a selection', function () {
const chart = _.first(vis.handler.charts);
const apply = chart.events[name](chart.series[0].chartEl);
expect(apply).to.be.a('function');
expect(apply).toBeInstanceOf(Function);

const els = getEls(vis.element, 3, 'div');
apply(els);
els.each(function () {
expect(d3.select(this).on(event)).to.be.a('function');
expect(d3.select(this).on(event)).toBeInstanceOf(Function);
});
});
});
Expand All @@ -119,83 +139,83 @@ describe('Vislib Dispatch Class Test Suite', function () {
checkBoundAddMethod('addClickEvent', 'click');

describe('addMousePointer method', function () {
it('should be a function', function () {
test('should be a function', function () {
vis.handler.charts.forEach(function (chart) {
const pointer = chart.events.addMousePointer;

expect(_.isFunction(pointer)).to.be(true);
expect(_.isFunction(pointer)).toBe(true);
});
});
});

describe('clickEvent handler', () => {
describe('for pie chart', () => {
it('prepares data points', () => {
test('prepares data points', () => {
const expectedResponse = [{ column: 0, row: 0, table: {}, value: 0 }];
const d = { rawData: { column: 0, row: 0, table: {}, value: 0 } };
const chart = _.first(vis.handler.charts);
const response = chart.events.clickEventResponse(d, { isSlices: true });
expect(response.data).to.eql(expectedResponse);
expect(response.data).toEqual(expectedResponse);
});

it('remove invalid points', () => {
test('remove invalid points', () => {
const expectedResponse = [{ column: 0, row: 0, table: {}, value: 0 }];
const d = {
rawData: { column: 0, row: 0, table: {}, value: 0 },
yRaw: { table: {}, value: 0 },
};
const chart = _.first(vis.handler.charts);
const response = chart.events.clickEventResponse(d, { isSlices: true });
expect(response.data).to.eql(expectedResponse);
expect(response.data).toEqual(expectedResponse);
});
});

describe('for xy charts', () => {
it('prepares data points', () => {
test('prepares data points', () => {
const expectedResponse = [{ column: 0, row: 0, table: {}, value: 0 }];
const d = { xRaw: { column: 0, row: 0, table: {}, value: 0 } };
const chart = _.first(vis.handler.charts);
const response = chart.events.clickEventResponse(d, { isSlices: false });
expect(response.data).to.eql(expectedResponse);
expect(response.data).toEqual(expectedResponse);
});

it('remove invalid points', () => {
test('remove invalid points', () => {
const expectedResponse = [{ column: 0, row: 0, table: {}, value: 0 }];
const d = {
xRaw: { column: 0, row: 0, table: {}, value: 0 },
yRaw: { table: {}, value: 0 },
};
const chart = _.first(vis.handler.charts);
const response = chart.events.clickEventResponse(d, { isSlices: false });
expect(response.data).to.eql(expectedResponse);
expect(response.data).toEqual(expectedResponse);
});
});
});
});

describe('Custom event handlers', function () {
it('should attach whatever gets passed on vis.on() to chart.events', function (done) {
test('should attach whatever gets passed on vis.on() to chart.events', function (done) {
const vis = getVis();
const mockUiState = getMockUiState();
vis.on('someEvent', _.noop);
vis.render(data, mockUiState);

vis.handler.charts.forEach(function (chart) {
expect(chart.events.listenerCount('someEvent')).to.be(1);
expect(chart.events.listenerCount('someEvent')).toBe(1);
});

destroyVis(vis);
done();
});

it('can be added after rendering', function () {
test('can be added after rendering', function () {
const vis = getVis();
const mockUiState = getMockUiState();
vis.render(data, mockUiState);
vis.on('someEvent', _.noop);

vis.handler.charts.forEach(function (chart) {
expect(chart.events.listenerCount('someEvent')).to.be(1);
expect(chart.events.listenerCount('someEvent')).toBe(1);
});

destroyVis(vis);
Expand Down
Loading

0 comments on commit 6a8fdaa

Please sign in to comment.