Merge branch 'master' of github.com:elastic/kibana into dev-cli/remov…

…e-cluster-detection

.github/CODEOWNERS

@@ -132,7 +132,7 @@
 /x-pack/test/functional_basic/apps/transform/ @elastic/ml-ui
 
 # Maps
-/x-pack/plugins/maps/ @elastic/kibana-gis
+#CC# /x-pack/plugins/maps/ @elastic/kibana-gis
 /x-pack/test/api_integration/apis/maps/ @elastic/kibana-gis
 /x-pack/test/functional/apps/maps/ @elastic/kibana-gis
 /x-pack/test/functional/es_archives/maps/ @elastic/kibana-gis

docs/settings/alert-action-settings.asciidoc

@@ -9,7 +9,7 @@ Alerts and actions are enabled by default in {kib}, but require you configure th
 
 . <<using-kibana-with-security,Set up {kib} to work with {stack} {security-features}>>.
 . <<configuring-tls-kib-es,Set up TLS encryption between {kib} and {es}>>.
-. <<general-alert-action-settings,Specify a value for `xpack.encryptedSavedObjects.encryptionKey`>>.
+. If you are using an *on-premises* Elastic Stack deployment, <<general-alert-action-settings,specify a value for `xpack.encryptedSavedObjects.encryptionKey`>>.
 
 You can configure the following settings in the `kibana.yml` file.
 

packages/kbn-config/src/__mocks__/env.ts

@@ -30,7 +30,6 @@ export function getEnvOptions(options: DeepPartial<EnvOptions> = {}): EnvOptions
     configs: options.configs || [],
     cliArgs: {
       dev: true,
-      open: false,
       quiet: false,
       silent: false,
       watch: false,

packages/kbn-config/src/env.ts

@@ -38,7 +38,6 @@ export interface CliArgs {
   watch: boolean;
   repl: boolean;
   basePath: boolean;
-  open: boolean;
   oss: boolean;
   /** @deprecated use disableOptimizer to know if the @kbn/optimizer is disabled in development */
   optimize?: boolean;

src/cli/cluster/cluster_manager.test.ts

@@ -38,7 +38,6 @@ import { Worker } from './worker';
 
 const CLI_ARGS: SomeCliArgs = {
   disableOptimizer: true,
-  open: false,
   oss: false,
   quiet: false,
   repl: false,

src/cli/cluster/cluster_manager.ts

@@ -18,10 +18,8 @@
  */
 
 import { resolve } from 'path';
-import { format as formatUrl } from 'url';
 import Fs from 'fs';
 
-import opn from 'opn';
 import { REPO_ROOT } from '@kbn/utils';
 import { FSWatcher } from 'chokidar';
 import * as Rx from 'rxjs';
@@ -41,7 +39,6 @@ export type SomeCliArgs = Pick<
   | 'silent'
   | 'repl'
   | 'disableOptimizer'
-  | 'open'
   | 'watch'
   | 'oss'
   | 'runExamples'
@@ -50,7 +47,7 @@ export type SomeCliArgs = Pick<
 >;
 
 const firstAllTrue = (...sources: Array<Rx.Observable<boolean>>) =>
-  Rx.combineLatest(...sources).pipe(
+  Rx.combineLatest(sources).pipe(
     filter((values) => values.every((v) => v === true)),
     take(1),
     mapTo(undefined)
@@ -144,17 +141,6 @@ export class ClusterManager {
       });
     });
 
-    if (opts.open) {
-      this.setupOpen(
-        formatUrl({
-          protocol: config.get('server.ssl.enabled') ? 'https' : 'http',
-          hostname: config.get('server.host'),
-          port: config.get('server.port'),
-          pathname: this.basePathProxy ? this.basePathProxy.basePath : '',
-        })
-      );
-    }
-
     if (opts.watch) {
       const pluginPaths = config.get<string[]>('plugins.paths');
       const scanDirs = [
@@ -206,14 +192,6 @@ export class ClusterManager {
     }
   }
 
-  setupOpen(openUrl: string) {
-    firstAllTrue(this.serverReady$, this.kbnOptimizerReady$)
-      .toPromise()
-      .then(() => {
-        opn(openUrl);
-      });
-  }
-
   setupWatching(extraPaths: string[], pluginInternalDirsIgnore: string[]) {
     // eslint-disable-next-line @typescript-eslint/no-var-requires
     const chokidar = require('chokidar');

src/cli/serve/serve.js

@@ -192,7 +192,6 @@ export default function (program) {
   if (DEV_MODE_SUPPORTED) {
     command
       .option('--dev', 'Run the server with development mode defaults')
-      .option('--open', 'Open a browser window to the base url after the server is started')
       .option('--ssl', 'Run the dev server using HTTPS')
       .option('--dist', 'Use production assets from kbn/optimizer')
       .option(
@@ -222,7 +221,6 @@ export default function (program) {
       configs: [].concat(opts.config || []),
       cliArgs: {
         dev: !!opts.dev,
-        open: !!opts.open,
         envName: unknownOptions.env ? unknownOptions.env.name : undefined,
         quiet: !!opts.quiet,
         silent: !!opts.silent,

src/core/test_helpers/kbn_server.ts

@@ -70,7 +70,6 @@ export function createRootWithSettings(
     configs: [],
     cliArgs: {
       dev: false,
-      open: false,
       quiet: false,
       silent: false,
       watch: false,

src/plugins/es_ui_shared/static/forms/components/fields/checkbox_field.tsx

@@ -30,7 +30,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const CheckBoxField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const CheckBoxField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const CheckBoxField = ({ field, euiFieldProps = {}, ...rest }: Props) =>
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiCheckbox

src/plugins/es_ui_shared/static/forms/components/fields/combobox_field.tsx

@@ -30,7 +30,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const ComboBoxField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const ComboBoxField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   // Errors for the comboBox value (the "array")
   const errorMessageField = field.getErrorsMessages();
 
@@ -87,7 +87,7 @@ export const ComboBoxField = ({ field, euiFieldProps = {}, ...rest }: Props) =>
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiComboBox

src/plugins/es_ui_shared/static/forms/components/fields/multi_select_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const MultiSelectField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const MultiSelectField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const MultiSelectField = ({ field, euiFieldProps = {}, ...rest }: Props)
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiSelectable

src/plugins/es_ui_shared/static/forms/components/fields/numeric_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const NumericField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const NumericField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const NumericField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiFieldNumber

src/plugins/es_ui_shared/static/forms/components/fields/radio_group_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const RadioGroupField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const RadioGroupField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const RadioGroupField = ({ field, euiFieldProps = {}, ...rest }: Props) =
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiRadioGroup

src/plugins/es_ui_shared/static/forms/components/fields/range_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const RangeField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const RangeField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
   const { onChange: onFieldChange } = field;
 
@@ -50,7 +50,7 @@ export const RangeField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiRange

src/plugins/es_ui_shared/static/forms/components/fields/select_field.tsx

@@ -34,7 +34,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const SelectField = ({ field, euiFieldProps, ...rest }: Props) => {
+export const SelectField = ({ field, euiFieldProps, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -44,7 +44,7 @@ export const SelectField = ({ field, euiFieldProps, ...rest }: Props) => {
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiSelect

src/plugins/es_ui_shared/static/forms/components/fields/super_select_field.tsx

@@ -32,7 +32,12 @@ interface Props {
   [key: string]: any;
 }
 
-export const SuperSelectField = ({ field, euiFieldProps = { options: [] }, ...rest }: Props) => {
+export const SuperSelectField = ({
+  field,
+  euiFieldProps = { options: [] },
+  idAria,
+  ...rest
+}: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -42,7 +47,7 @@ export const SuperSelectField = ({ field, euiFieldProps = { options: [] }, ...re
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiSuperSelect

src/plugins/es_ui_shared/static/forms/components/fields/text_area_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const TextAreaField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const TextAreaField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const TextAreaField = ({ field, euiFieldProps = {}, ...rest }: Props) =>
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiTextArea

src/plugins/es_ui_shared/static/forms/components/fields/text_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const TextField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const TextField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   return (
@@ -39,7 +39,7 @@ export const TextField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiFieldText

src/plugins/es_ui_shared/static/forms/components/fields/toggle_field.tsx

@@ -29,7 +29,7 @@ interface Props {
   [key: string]: any;
 }
 
-export const ToggleField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
+export const ToggleField = ({ field, euiFieldProps = {}, idAria, ...rest }: Props) => {
   const { isInvalid, errorMessage } = getFieldValidityAndErrorMessage(field);
 
   // Shim for sufficient overlap between EuiSwitchEvent and FieldHook[onChange] event
@@ -46,7 +46,7 @@ export const ToggleField = ({ field, euiFieldProps = {}, ...rest }: Props) => {
       error={errorMessage}
       isInvalid={isInvalid}
       fullWidth
-      describedByIds={rest.idAria ? [rest.idAria] : undefined}
+      describedByIds={idAria ? [idAria] : undefined}
       {...rest}
     >
       <EuiSwitch

src/plugins/vis_type_timeseries/common/constants.ts

@@ -19,3 +19,7 @@
 
 export const MAX_BUCKETS_SETTING = 'metrics:max_buckets';
 export const INDEXES_SEPARATOR = ',';
+
+export const ROUTES = {
+  VIS_DATA: '/api/metrics/vis/data',
+};