Skip to content

Commit

Permalink
avoid using .all stdout collection, it seems unreliable
Browse files Browse the repository at this point in the history
  • Loading branch information
spalger committed Aug 27, 2020
1 parent eefa5b1 commit 7143db3
Showing 1 changed file with 2 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,10 @@ it('builds a generated plugin into a viable archive', async () => {
[require.resolve('../../../../scripts/generate_plugin'), '-y', '--name', 'fooTestPlugin'],
{
cwd: REPO_ROOT,
all: true,
}
);

expect(generateProc.all).toMatchInlineSnapshot(`
expect(generateProc.stdout).toMatchInlineSnapshot(`
" succ 🎉
Your plugin has been created in plugins/foo_test_plugin
Expand All @@ -63,10 +62,9 @@ it('builds a generated plugin into a viable archive', async () => {

const buildProc = await execa('yarn', ['build', '--kibana-version', '7.5.0'], {
cwd: PLUGIN_DIR,
all: true,
});

expect(buildProc.all).toMatchInlineSnapshot(`
expect(buildProc.stdout).toMatchInlineSnapshot(`
"yarn run <version>
$ yarn plugin-helpers build --kibana-version 7.5.0
$ node ../../scripts/plugin_helpers build --kibana-version 7.5.0
Expand Down

0 comments on commit 7143db3

Please sign in to comment.