Kibana should allow a min_age setting of 0ms in ILM policy phases

elastic · Dec 20, 2019 · 809b32f · 809b32f
1 parent fc999e5
commit 809b32f
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/...lugins/index_lifecycle_management/public/sections/edit_policy/components/min_age_input.js b/...lugins/index_lifecycle_management/public/sections/edit_policy/components/min_age_input.js
@@ -131,7 +131,7 @@ export const MinAgeInput = props => {
             onChange={async e => {
               setPhaseData(PHASE_ROLLOVER_MINIMUM_AGE, e.target.value);
             }}
-            min={1}
+            min={0}
           />
         </ErrableFormRow>
       </EuiFlexItem>

diff --git a/x-pack/legacy/plugins/index_lifecycle_management/public/store/selectors/lifecycle.js b/x-pack/legacy/plugins/index_lifecycle_management/public/store/selectors/lifecycle.js
@@ -84,6 +84,11 @@ export const positiveNumbersAboveZeroErrorMessage = i18n.translate(
   }
 );
 
+export const positiveNumbersEqualAboveZeroErrorMessage =
+  i18n.translate('xpack.indexLifecycleMgmt.editPolicy.positiveNumberAboveZeroRequiredError', {
+    defaultMessage: 'Only numbers equal to or above 0 are allowed.'
+  });
+
 export const validatePhase = (type, phase, errors) => {
   const phaseErrors = {};
 
@@ -123,11 +128,12 @@ export const validatePhase = (type, phase, errors) => {
       } else if (
         (numberedAttribute === PHASE_ROLLOVER_MINIMUM_AGE ||
           numberedAttribute === PHASE_PRIMARY_SHARD_COUNT) &&
-        phase[numberedAttribute] < 1
+        phase[numberedAttribute] < 0
       ) {
-        phaseErrors[numberedAttribute] = [positiveNumbersAboveZeroErrorMessage];
+        phaseErrors[numberedAttribute] = [positiveNumbersEqualAboveZeroErrorMessage];
       }
     }
+
   }
   if (phase[PHASE_ROLLOVER_ENABLED]) {
     if (
@@ -161,6 +167,7 @@ export const validatePhase = (type, phase, errors) => {
   }
 
   if (phase[PHASE_FORCE_MERGE_ENABLED]) {
+
     if (!isNumber(phase[PHASE_FORCE_MERGE_SEGMENTS])) {
       phaseErrors[PHASE_FORCE_MERGE_SEGMENTS] = [numberRequiredMessage];
     } else if (phase[PHASE_FORCE_MERGE_SEGMENTS] < 1) {