More PR review feedback

elastic · Feb 15, 2020 · 843f18d · 843f18d
1 parent 4d631da
commit 843f18d
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/x-pack/plugins/security/public/session/session_expired.test.ts b/x-pack/plugins/security/public/session/session_expired.test.ts
@@ -45,21 +45,16 @@ describe('#logout', () => {
     await expect(newUrlPromise).resolves.toBe(`${LOGOUT_URL}?msg=SESSION_EXPIRED${next}`);
   });
 
-  it(`checks sessionStorage for the provider name for this tenant`, async () => {
-    const sessionExpired = new SessionExpired(LOGOUT_URL, TENANT);
-    sessionExpired.logout();
-
-    expect(mockGetItem).toHaveBeenCalledTimes(1);
-    expect(mockGetItem).toHaveBeenCalledWith(`${TENANT}/session_provider`);
-  });
-
   it(`adds 'provider' parameter when sessionStorage contains the provider name for this tenant`, async () => {
     const providerName = 'basic';
     mockGetItem.mockReturnValueOnce(providerName);
 
     const sessionExpired = new SessionExpired(LOGOUT_URL, TENANT);
     sessionExpired.logout();
 
+    expect(mockGetItem).toHaveBeenCalledTimes(1);
+    expect(mockGetItem).toHaveBeenCalledWith(`${TENANT}/session_provider`);
+
     const next = `&next=${encodeURIComponent(CURRENT_URL)}`;
     const provider = `&provider=${providerName}`;
     await expect(newUrlPromise).resolves.toBe(