Skip to content

Commit

Permalink
Fix and re-enable Vega test to be consistent with development/CI (#11…
Browse files Browse the repository at this point in the history
…0971) (#112384)

* Fix and re-enable Vega test to be consistent with development/CI

* Remove skip comments

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
DianaDerevyankina and kibanamachine authored Sep 16, 2021
1 parent 6260bab commit 8561af0
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions src/plugins/vis_types/vega/public/vega_visualization.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,7 @@ describe('VegaVisualizations', () => {
mockWidth.mockRestore();
mockHeight.mockRestore();
});

// SKIP: https://github.com/elastic/kibana/issues/83385
test.skip('should show vegalite graph and update on resize (may fail in dev env)', async () => {
test('should show vegalite graph and update on resize (may fail in dev env)', async () => {
let vegaVis;
try {
vegaVis = new VegaVisualization(domNode, jest.fn());
Expand All @@ -105,7 +103,7 @@ describe('VegaVisualizations', () => {
expect(domNode.innerHTML).toMatchSnapshot();

mockedWidthValue = 256;
mockedHeightValue = 256;
mockedHeightValue = 250;

await vegaVis.vegaView.resize();

Expand All @@ -115,8 +113,7 @@ describe('VegaVisualizations', () => {
}
});

// SKIP: https://github.com/elastic/kibana/issues/83385
test.skip('should show vega graph (may fail in dev env)', async () => {
test('should show vega graph (may fail in dev env)', async () => {
let vegaVis;
try {
vegaVis = new VegaVisualization(domNode, jest.fn());
Expand Down

0 comments on commit 8561af0

Please sign in to comment.