[Upgrade Assistant] Add A11y Tests (#90265)

* Added overview a11y test. Added data test subjects to the tabs in the app.

* Added data test subjects for all tabs and the detail panel on the indidual pages. Updated tests to wait for detail panel to be visible before taking snapshot.

* Updated snapshot for upgrade assistant jest tests.

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

x-pack/plugins/upgrade_assistant/public/application/components/tabs.tsx

@@ -190,13 +190,15 @@ export class UpgradeAssistantTabs extends React.Component<Props, TabsState> {
     return [
       {
         id: 'overview',
+        'data-test-subj': 'upgradeAssistantOverviewTab',
         name: i18n.translate('xpack.upgradeAssistant.overviewTab.overviewTabTitle', {
           defaultMessage: 'Overview',
         }),
         content: <OverviewTab checkupData={checkupData} {...commonProps} />,
       },
       {
         id: 'cluster',
+        'data-test-subj': 'upgradeAssistantClusterTab',
         name: i18n.translate('xpack.upgradeAssistant.checkupTab.clusterTabLabel', {
           defaultMessage: 'Cluster',
         }),
@@ -213,6 +215,7 @@ export class UpgradeAssistantTabs extends React.Component<Props, TabsState> {
       },
       {
         id: 'indices',
+        'data-test-subj': 'upgradeAssistantIndicesTab',
         name: i18n.translate('xpack.upgradeAssistant.checkupTab.indicesTabLabel', {
           defaultMessage: 'Indices',
         }),

x-pack/plugins/upgrade_assistant/public/application/components/tabs/checkup/checkup_tab.tsx

@@ -95,7 +95,11 @@ export const CheckupTab: FunctionComponent<CheckupTabProps> = ({
     <>
       <EuiSpacer />
       <EuiText grow={false}>
-        <p>
+        <p
+          data-test-subj={`upgradeAssistant${
+            checkupLabel.charAt(0).toUpperCase() + checkupLabel.slice(1)
+          }TabDetail`}
+        >
           <FormattedMessage
             id="xpack.upgradeAssistant.checkupTab.tabDetail"
             defaultMessage="These {strongCheckupLabel} issues need your attention. Resolve them before upgrading to Elasticsearch {nextEsVersion}."

x-pack/plugins/upgrade_assistant/public/application/components/tabs/overview/index.tsx

@@ -31,7 +31,7 @@ export const OverviewTab: FunctionComponent<UpgradeAssistantTabProps> = (props)
     <>
       <EuiSpacer />
 
-      <EuiText grow={false}>
+      <EuiText data-test-subj="upgradeAssistantOverviewTabDetail" grow={false}>
         <p>
           <FormattedMessage
             id="xpack.upgradeAssistant.overviewTab.tabDetail"

x-pack/test/accessibility/apps/upgrade_assistant.ts

@@ -0,0 +1,44 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+import { FtrProviderContext } from '../ftr_provider_context';
+
+export default function ({ getService, getPageObjects }: FtrProviderContext) {
+  const PageObjects = getPageObjects(['upgradeAssistant', 'common']);
+  const a11y = getService('a11y');
+  const testSubjects = getService('testSubjects');
+  const retry = getService('retry');
+
+  describe('Upgrade Assistant Home', () => {
+    before(async () => {
+      await PageObjects.upgradeAssistant.navigateToPage();
+    });
+
+    it('Overview Tab', async () => {
+      await retry.waitFor('Upgrade Assistant overview tab to be visible', async () => {
+        return testSubjects.exists('upgradeAssistantOverviewTabDetail');
+      });
+      await a11y.testAppSnapshot();
+    });
+
+    it('Cluster Tab', async () => {
+      await testSubjects.click('upgradeAssistantClusterTab');
+      await retry.waitFor('Upgrade Assistant Cluster tab to be visible', async () => {
+        return testSubjects.exists('upgradeAssistantClusterTabDetail');
+      });
+      await a11y.testAppSnapshot();
+    });
+
+    it('Indices Tab', async () => {
+      await testSubjects.click('upgradeAssistantIndicesTab');
+      await retry.waitFor('Upgrade Assistant Cluster tab to be visible', async () => {
+        return testSubjects.exists('upgradeAssistantIndexTabDetail');
+      });
+      await a11y.testAppSnapshot();
+    });
+  });
+}

x-pack/test/accessibility/config.ts

@@ -31,6 +31,7 @@ export default async function ({ readConfigFile }: FtrConfigProviderContext) {
       require.resolve('./apps/index_lifecycle_management'),
       require.resolve('./apps/ml'),
       require.resolve('./apps/lens'),
+      require.resolve('./apps/upgrade_assistant'),
     ],
 
     pageObjects,