applying review feedback

src/plugins/data/common/search/tabify/index.ts

@@ -17,14 +17,24 @@
  * under the License.
  */
 
+import { SearchResponse } from 'elasticsearch';
 import { SearchSource } from '../search_source';
 import { tabifyAggResponse } from './tabify';
-import { tabifyDocs } from './tabify_docs';
+import { tabifyDocs, TabifyDocsOptions } from './tabify_docs';
+import { TabbedResponseWriterOptions } from './types';
 
-export const tabify = (searchSource: SearchSource, esResponse: any, opts: any) => {
+export const tabify = (
+  searchSource: SearchSource,
+  esResponse: SearchResponse<unknown>,
+  opts: Partial<TabbedResponseWriterOptions> | TabifyDocsOptions
+) => {
   return !esResponse.aggregations
-    ? tabifyDocs(esResponse, searchSource.getField('index'), opts)
-    : tabifyAggResponse(searchSource.getField('aggs'), esResponse, opts);
+    ? tabifyDocs(esResponse, searchSource.getField('index'), opts as TabifyDocsOptions)
+    : tabifyAggResponse(
+        searchSource.getField('aggs'),
+        esResponse,
+        opts as Partial<TabbedResponseWriterOptions>
+      );
 };
 
 export { tabifyAggResponse } from './tabify';

src/plugins/data/common/search/tabify/tabify_docs.test.ts

@@ -57,21 +57,21 @@ describe('tabifyDocs', () => {
 
   it('converts fields by default', () => {
     const table = tabifyDocs(response, index);
-    expect(table).toMatchSnapshot('converts fields by default');
+    expect(table).toMatchSnapshot();
   });
 
   it('converts source if option is set', () => {
     const table = tabifyDocs(response, index, { source: true });
-    expect(table).toMatchSnapshot('converts source if option is set');
+    expect(table).toMatchSnapshot();
   });
 
   it('skips nested fields if option is set', () => {
     const table = tabifyDocs(response, index, { shallow: true });
-    expect(table).toMatchSnapshot('skips nested fields if option is set');
+    expect(table).toMatchSnapshot();
   });
 
   it('works without provided index pattern', () => {
     const table = tabifyDocs(response);
-    expect(table).toMatchSnapshot('works without provided index pattern');
+    expect(table).toMatchSnapshot();
   });
 });

src/plugins/data/common/search/tabify/tabify_docs.ts

@@ -18,9 +18,9 @@
  */
 
 import { SearchResponse } from 'elasticsearch';
-import { first, each, isPlainObject } from 'lodash';
+import { isPlainObject } from 'lodash';
 import { IndexPattern } from '../../index_patterns/index_patterns';
-import { Datatable, DatatableColumn } from '../../../../expressions/common';
+import { Datatable, DatatableColumn, DatatableColumnType } from '../../../../expressions/common';
 
 export function flattenHit(
   hit: Record<string, any>,
@@ -37,12 +37,11 @@ export function flattenHit(
 
       if (!shallow) {
         const isNestedField = field?.type === 'nested';
-        const isArrayOfObjects = Array.isArray(val) && isPlainObject(first(val));
-        if (isArrayOfObjects && !isNestedField) {
-          each(val as object, (v) => flatten(v, key + '.'));
+        if (Array.isArray(val) && !isNestedField) {
+          val.forEach((v) => isPlainObject(v) && flatten(v, key + '.'));
           continue;
         }
-      } else if (flat[key] !== void 0) {
+      } else if (flat[key] !== undefined) {
         continue;
       }
 
@@ -86,9 +85,9 @@ export const tabifyDocs = (
       const flat = flattenHit(toConvert, index, params.shallow);
       for (const [key, value] of Object.entries(flat)) {
         const field = index?.fields.getByName(key);
-        if (!columns.find((c) => c.id === (field?.name || key))) {
-          const fieldName = field?.name || key;
-          const fieldType = (field?.type as any) || typeof value;
+        const fieldName = field?.name || key;
+        if (!columns.find((c) => c.id === fieldName)) {
+          const fieldType = (field?.type as DatatableColumnType) || typeof value;
           const formatter = field && index?.getFormatterForField(field);
           columns.push({
             id: fieldName,