Merge remote-tracking branch 'upstream/master' into fix-agg-datatable…

…-type
elastic · Feb 8, 2021 · 90c34b1 · 90c34b1
2 parents 20b3c9f + 2279c06
commit 90c34b1
Show file tree

Hide file tree

Showing 224 changed files with 4,800 additions and 1,225 deletions.
diff --git a/.bazelrc b/.bazelrc
@@ -2,8 +2,17 @@
 # Import shared settings first so we can override below
 import %workspace%/.bazelrc.common
 
+## Disabled for now
 # Remote cache settings for local env
 # build --remote_cache=https://storage.googleapis.com/kibana-bazel-cache
 # build --incompatible_remote_results_ignore_disk=true
 # build --remote_accept_cached=true
 # build --remote_upload_local_results=false
+
+# BuildBuddy
+## Metadata settings
+build --workspace_status_command=$(pwd)/src/dev/bazel_workspace_status.sh
+# Enable this in case you want to share your build info
+# build --build_metadata=VISIBILITY=PUBLIC
+build --build_metadata=TEST_GROUPS=//packages
+
diff --git a/.eslintignore b/.eslintignore
@@ -16,6 +16,7 @@ target
 snapshots.js
 
 !/.eslintrc.js
+!.storybook
 
 # plugin overrides
 /src/core/lib/kbn_internal_native_observable

diff --git a/.eslintrc.js b/.eslintrc.js
@@ -1112,6 +1112,8 @@ module.exports = {
 
     /**
      * Enterprise Search overrides
+     * NOTE: We also have a single rule at the bottom of the file that
+     * overrides Prettier's default of not linting unnecessary backticks
      */
     {
       // All files
@@ -1268,6 +1270,16 @@ module.exports = {
         ...require('eslint-config-prettier/@typescript-eslint').rules,
       },
     },
+    /**
+     * Enterprise Search Prettier override
+     * Lints unnecessary backticks - @see https://github.com/prettier/eslint-config-prettier/blob/main/README.md#forbid-unnecessary-backticks
+     */
+    {
+      files: ['x-pack/plugins/enterprise_search/**/*.{ts,tsx}'],
+      rules: {
+        quotes: ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
+      },
+    },
 
     {
       files: [

diff --git a/...na-plugin-core-server.savedobjectserrorhelpers.createindexaliasnotfounderror.md b/...na-plugin-core-server.savedobjectserrorhelpers.createindexaliasnotfounderror.md
@@ -0,0 +1,22 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [SavedObjectsErrorHelpers](./kibana-plugin-core-server.savedobjectserrorhelpers.md) &gt; [createIndexAliasNotFoundError](./kibana-plugin-core-server.savedobjectserrorhelpers.createindexaliasnotfounderror.md)
+
+## SavedObjectsErrorHelpers.createIndexAliasNotFoundError() method
+
+<b>Signature:</b>
+
+```typescript
+static createIndexAliasNotFoundError(alias: string): DecoratedError;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  alias | <code>string</code> |  |
+
+<b>Returns:</b>
+
+`DecoratedError`
+
diff --git a/...-plugin-core-server.savedobjectserrorhelpers.decorateindexaliasnotfounderror.md b/...-plugin-core-server.savedobjectserrorhelpers.decorateindexaliasnotfounderror.md
@@ -0,0 +1,23 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [SavedObjectsErrorHelpers](./kibana-plugin-core-server.savedobjectserrorhelpers.md) &gt; [decorateIndexAliasNotFoundError](./kibana-plugin-core-server.savedobjectserrorhelpers.decorateindexaliasnotfounderror.md)
+
+## SavedObjectsErrorHelpers.decorateIndexAliasNotFoundError() method
+
+<b>Signature:</b>
+
+```typescript
+static decorateIndexAliasNotFoundError(error: Error, alias: string): DecoratedError;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  error | <code>Error</code> |  |
+|  alias | <code>string</code> |  |
+
+<b>Returns:</b>
+
+`DecoratedError`
+
diff --git a/...ore/server/kibana-plugin-core-server.savedobjectserrorhelpers.isgeneralerror.md b/...ore/server/kibana-plugin-core-server.savedobjectserrorhelpers.isgeneralerror.md
@@ -0,0 +1,22 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-core-server](./kibana-plugin-core-server.md) &gt; [SavedObjectsErrorHelpers](./kibana-plugin-core-server.savedobjectserrorhelpers.md) &gt; [isGeneralError](./kibana-plugin-core-server.savedobjectserrorhelpers.isgeneralerror.md)
+
+## SavedObjectsErrorHelpers.isGeneralError() method
+
+<b>Signature:</b>
+
+```typescript
+static isGeneralError(error: Error | DecoratedError): boolean;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  error | <code>Error &#124; DecoratedError</code> |  |
+
+<b>Returns:</b>
+
+`boolean`
+
diff --git a/docs/development/core/server/kibana-plugin-core-server.savedobjectserrorhelpers.md b/docs/development/core/server/kibana-plugin-core-server.savedobjectserrorhelpers.md
@@ -18,6 +18,7 @@ export declare class SavedObjectsErrorHelpers
 |  [createBadRequestError(reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.createbadrequesterror.md) | <code>static</code> |  |
 |  [createConflictError(type, id, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.createconflicterror.md) | <code>static</code> |  |
 |  [createGenericNotFoundError(type, id)](./kibana-plugin-core-server.savedobjectserrorhelpers.creategenericnotfounderror.md) | <code>static</code> |  |
+|  [createIndexAliasNotFoundError(alias)](./kibana-plugin-core-server.savedobjectserrorhelpers.createindexaliasnotfounderror.md) | <code>static</code> |  |
 |  [createInvalidVersionError(versionInput)](./kibana-plugin-core-server.savedobjectserrorhelpers.createinvalidversionerror.md) | <code>static</code> |  |
 |  [createTooManyRequestsError(type, id)](./kibana-plugin-core-server.savedobjectserrorhelpers.createtoomanyrequestserror.md) | <code>static</code> |  |
 |  [createUnsupportedTypeError(type)](./kibana-plugin-core-server.savedobjectserrorhelpers.createunsupportedtypeerror.md) | <code>static</code> |  |
@@ -27,6 +28,7 @@ export declare class SavedObjectsErrorHelpers
 |  [decorateEsUnavailableError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decorateesunavailableerror.md) | <code>static</code> |  |
 |  [decorateForbiddenError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decorateforbiddenerror.md) | <code>static</code> |  |
 |  [decorateGeneralError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decorategeneralerror.md) | <code>static</code> |  |
+|  [decorateIndexAliasNotFoundError(error, alias)](./kibana-plugin-core-server.savedobjectserrorhelpers.decorateindexaliasnotfounderror.md) | <code>static</code> |  |
 |  [decorateNotAuthorizedError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decoratenotauthorizederror.md) | <code>static</code> |  |
 |  [decorateRequestEntityTooLargeError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decoraterequestentitytoolargeerror.md) | <code>static</code> |  |
 |  [decorateTooManyRequestsError(error, reason)](./kibana-plugin-core-server.savedobjectserrorhelpers.decoratetoomanyrequestserror.md) | <code>static</code> |  |
@@ -35,6 +37,7 @@ export declare class SavedObjectsErrorHelpers
 |  [isEsCannotExecuteScriptError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isescannotexecutescripterror.md) | <code>static</code> |  |
 |  [isEsUnavailableError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isesunavailableerror.md) | <code>static</code> |  |
 |  [isForbiddenError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isforbiddenerror.md) | <code>static</code> |  |
+|  [isGeneralError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isgeneralerror.md) | <code>static</code> |  |
 |  [isInvalidVersionError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isinvalidversionerror.md) | <code>static</code> |  |
 |  [isNotAuthorizedError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isnotauthorizederror.md) | <code>static</code> |  |
 |  [isNotFoundError(error)](./kibana-plugin-core-server.savedobjectserrorhelpers.isnotfounderror.md) | <code>static</code> |  |

diff --git a/...t/plugins/data/server/kibana-plugin-plugins-data-server.indexpatternsfetcher.md b/...t/plugins/data/server/kibana-plugin-plugins-data-server.indexpatternsfetcher.md
@@ -22,4 +22,5 @@ export declare class IndexPatternsFetcher
 |  --- | --- | --- |
 |  [getFieldsForTimePattern(options)](./kibana-plugin-plugins-data-server.indexpatternsfetcher.getfieldsfortimepattern.md) |  | Get a list of field objects for a time pattern |
 |  [getFieldsForWildcard(options)](./kibana-plugin-plugins-data-server.indexpatternsfetcher.getfieldsforwildcard.md) |  | Get a list of field objects for an index pattern that may contain wildcards |
+|  [validatePatternListActive(patternList)](./kibana-plugin-plugins-data-server.indexpatternsfetcher.validatepatternlistactive.md) |  | Returns an index pattern list of only those index pattern strings in the given list that return indices |
 
diff --git a/...na-plugin-plugins-data-server.indexpatternsfetcher.validatepatternlistactive.md b/...na-plugin-plugins-data-server.indexpatternsfetcher.validatepatternlistactive.md
@@ -0,0 +1,24 @@
+<!-- Do not edit this file. It is automatically generated by API Documenter. -->
+
+[Home](./index.md) &gt; [kibana-plugin-plugins-data-server](./kibana-plugin-plugins-data-server.md) &gt; [IndexPatternsFetcher](./kibana-plugin-plugins-data-server.indexpatternsfetcher.md) &gt; [validatePatternListActive](./kibana-plugin-plugins-data-server.indexpatternsfetcher.validatepatternlistactive.md)
+
+## IndexPatternsFetcher.validatePatternListActive() method
+
+Returns an index pattern list of only those index pattern strings in the given list that return indices
+
+<b>Signature:</b>
+
+```typescript
+validatePatternListActive(patternList: string[]): Promise<string[]>;
+```
+
+## Parameters
+
+|  Parameter | Type | Description |
+|  --- | --- | --- |
+|  patternList | <code>string[]</code> |  |
+
+<b>Returns:</b>
+
+`Promise<string[]>`
+
diff --git a/docs/setup/docker.asciidoc b/docs/setup/docker.asciidoc
@@ -11,12 +11,8 @@ A list of all published Docker images and tags is available at
 https://www.docker.elastic.co[www.docker.elastic.co]. The source code is in
 https://github.com/elastic/dockerfiles/tree/{branch}/kibana[GitHub].
 
-These images are free to use under the Elastic license. They contain open source
-and free commercial features and access to paid commercial features.
-<<managing-licenses,Start a 30-day trial>> to try out all of the
-paid commercial features. See the
-https://www.elastic.co/subscriptions[Subscriptions] page for information about
-Elastic license levels.
+These images contain both free and subscription features.
+<<managing-licenses,Start a 30-day trial>> to try out all of the features.
 
 [float]
 [[pull-image]]

diff --git a/docs/user/alerting/action-types/email.asciidoc b/docs/user/alerting/action-types/email.asciidoc
@@ -14,7 +14,7 @@ Name::      The name of the connector. The name is used to identify a  connector
 Sender::    The from address for all emails sent with this connector, specified in `user@host-name` format.
 Host::      Host name of the service provider. If you are using the <<action-settings, `xpack.actions.allowedHosts`>> setting, make sure this hostname is added to the allowed hosts.
 Port::      The port to connect to on the service provider.
-Secure::    If true the connection will use TLS when connecting to the service provider. See https://nodemailer.com/smtp/#tls-options[nodemailer TLS documentation] for more information.
+Secure::    If true, the connection will use TLS when connecting to the service provider. Refer to the https://nodemailer.com/smtp/#tls-options[Nodemailer TLS documentation] for more information.  If not true, the connection will initially connect over TCP, then attempt to switch to TLS via the SMTP STARTTLS command.
 Username::  username for 'login' type authentication.
 Password::  password for 'login' type authentication.
 
@@ -92,6 +92,8 @@ systems, refer to:
 * <<exchange>>
 * <<amazon-ses>>
 
+For other email servers, you can check the list of well-known services that Nodemailer supports in the JSON file https://github.com/nodemailer/nodemailer/blob/master/lib/well-known/services.json[well-known/services.json].  The properties of the objects in those files &mdash; `host`, `port`, and `secure` &mdash; correspond to the same email action configuration properties.  A missing `secure` property in the "well-known/services.json" file is considered `false`.  Typically, `port: 465` uses `secure: true`, and `port: 25` and `port: 587` use `secure: false`.
+
 [float]
 [[gmail]]
 ===== Sending email from Gmail
@@ -109,7 +111,6 @@ https://mail.google.com[Gmail] SMTP service:
     user: <username>
     password: <password>
 --------------------------------------------------
-// CONSOLE
 
 If you get an authentication error that indicates that you need to continue the
 sign-in process from a web browser when the action attempts to send email, you need
@@ -131,9 +132,9 @@ https://www.outlook.com/[Outlook.com] SMTP service:
 [source,text]
 --------------------------------------------------
 config:
-    host: smtp-mail.outlook.com
-    port: 465
-    secure: true
+    host: smtp.office365.com
+    port: 587
+    secure: false
 secrets:
     user: <email.address>
     password: <password>
@@ -163,7 +164,7 @@ secrets:
     user: <username>
     password: <password>
 --------------------------------------------------
-<1> `smtp.host` varies depending on the region
+<1> `config.host` varies depending on the region
 
 NOTE:   You must use your Amazon SES SMTP credentials to send email through
         Amazon SES. For more information, see

diff --git a/docs/user/alerting/geo-alert-types.asciidoc b/docs/user/alerting/geo-alert-types.asciidoc
@@ -2,13 +2,8 @@
 [[geo-alert-types]]
 == Geo alert types
 
-experimental[] Two additional stack alerts are available:
-<<alert-type-tracking-threshold>> and <<alert-type-tracking-containment>>. To enable,
-add the following configuration to your `kibana.yml`:
-
-```yml
-xpack.stack_alerts.enableGeoAlerting: true
-```
+Two additional stack alerts are available:
+<<alert-type-tracking-threshold>> and <<alert-type-tracking-containment>>.
 
 As with other stack alerts, you need `all` access to the *Stack Alerts* feature
 to be able to create and edit either of the geo alerts.

diff --git a/docs/user/reporting/reporting-troubleshooting.asciidoc b/docs/user/reporting/reporting-troubleshooting.asciidoc
@@ -15,6 +15,7 @@ Having trouble? Here are solutions to common problems you might encounter while
 * <<reporting-troubleshooting-error-messages>>
 * <<reporting-troubleshooting-puppeteer-debug-logs>>
 * <<reporting-troubleshooting-system-requirements>>
+* <<reporting-troubleshooting-arm-systems>>
 
 [float]
 [[reporting-diagnostics]]
@@ -156,3 +157,9 @@ requests to render.
 
 If the {kib} instance doesn't have enough memory to run the report, the report fails with an error such as `Error: Page crashed!`
 In this case, try increasing the memory for the {kib} instance to 2GB.
+
+[float]
+[[reporting-troubleshooting-arm-systems]]
+=== ARM systems
+
+Chromium is not compatible with ARM RHEL/CentOS.
diff --git a/package.json b/package.json
@@ -220,7 +220,7 @@
     "http-proxy-agent": "^2.1.0",
     "https-proxy-agent": "^5.0.0",
     "idx": "^2.5.6",
-    "immer": "^1.5.0",
+    "immer": "^8.0.1",
     "inline-style": "^2.0.0",
     "intl": "^1.2.5",
     "intl-format-cache": "^2.1.0",
@@ -636,7 +636,7 @@
     "eslint-plugin-ban": "^1.4.0",
     "eslint-plugin-cypress": "^2.11.2",
     "eslint-plugin-eslint-comments": "^3.2.0",
-    "eslint-plugin-import": "^2.19.1",
+    "eslint-plugin-import": "^2.22.1",
     "eslint-plugin-jest": "^24.0.2",
     "eslint-plugin-jsx-a11y": "^6.2.3",
     "eslint-plugin-mocha": "^6.2.2",

diff --git a/packages/kbn-es-archiver/src/actions/empty_kibana_index.ts b/packages/kbn-es-archiver/src/actions/empty_kibana_index.ts
@@ -25,5 +25,6 @@ export async function emptyKibanaIndexAction({
 
   await cleanKibanaIndices({ client, stats, log, kibanaPluginIds });
   await migrateKibanaIndex({ client, kbnClient });
-  return stats;
+  stats.createdIndex('.kibana');
+  return stats.toJSON();
 }
diff --git a/packages/kbn-es-archiver/src/es_archiver.ts b/packages/kbn-es-archiver/src/es_archiver.ts
@@ -155,7 +155,7 @@ export class EsArchiver {
    *  @return Promise
    */
   async emptyKibanaIndex() {
-    await emptyKibanaIndexAction({
+    return await emptyKibanaIndexAction({
       client: this.client,
       log: this.log,
       kbnClient: this.kbnClient,

diff --git a/packages/kbn-es-archiver/src/lib/indices/kibana_index.ts b/packages/kbn-es-archiver/src/lib/indices/kibana_index.ts
@@ -82,7 +82,9 @@ export async function migrateKibanaIndex({
  */
 async function fetchKibanaIndices(client: Client) {
   const resp = await client.cat.indices<unknown>({ index: '.kibana*', format: 'json' });
-  const isKibanaIndex = (index: string) => /^\.kibana(:?_\d*)?$/.test(index);
+  const isKibanaIndex = (index: string) =>
+    /^\.kibana(:?_\d*)?$/.test(index) ||
+    /^\.kibana(_task_manager)?_(pre)?\d+\.\d+\.\d+/.test(index);
 
   if (!Array.isArray(resp.body)) {
     throw new Error(`expected response to be an array ${inspect(resp.body)}`);
@@ -115,7 +117,7 @@ export async function cleanKibanaIndices({
   while (true) {
     const resp = await client.deleteByQuery(
       {
-        index: `.kibana`,
+        index: `.kibana,.kibana_task_manager`,
         body: {
           query: {
             bool: {
@@ -129,7 +131,7 @@ export async function cleanKibanaIndices({
         },
       },
       {
-        ignore: [409],
+        ignore: [404, 409],
       }
     );