[Upgrade Assistant] Support Kibana deprecations (#97159) (#98911)

elastic · Apr 30, 2021 · 92ead83 · 92ead83
1 parent 2837125
commit 92ead83
Show file tree

Hide file tree

Showing 62 changed files with 2,282 additions and 957 deletions.
diff --git a/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json b/x-pack/plugins/telemetry_collection_xpack/schema/xpack_plugins.json
@@ -5314,7 +5314,10 @@
             "deprecation_logging": {
               "properties": {
                 "enabled": {
-                  "type": "boolean"
+                  "type": "boolean",
+                  "_meta": {
+                    "description": "Whether user has enabled Elasticsearch deprecation logging"
+                  }
                 }
               }
             }
@@ -5323,13 +5326,28 @@
         "ui_open": {
           "properties": {
             "cluster": {
-              "type": "long"
+              "type": "long",
+              "_meta": {
+                "description": "Number of times a user viewed the list of Elasticsearch cluster deprecations."
+              }
             },
             "indices": {
-              "type": "long"
+              "type": "long",
+              "_meta": {
+                "description": "Number of times a user viewed the list of Elasticsearch index deprecations."
+              }
             },
             "overview": {
-              "type": "long"
+              "type": "long",
+              "_meta": {
+                "description": "Number of times a user viewed the Overview page."
+              }
+            },
+            "kibana": {
+              "type": "long",
+              "_meta": {
+                "description": "Number of times a user viewed the list of Kibana deprecations"
+              }
             }
           }
         },

diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json
@@ -22111,15 +22111,9 @@
     "xpack.uiActionsEnhanced.drilldowns.urlDrilldownValidation.urlFormatGeneralErrorMessage": "無効なフォーマット。例：{exampleUrl}",
     "xpack.upgradeAssistant.appTitle": "{version} アップグレードアシスタント",
     "xpack.upgradeAssistant.checkupTab.changeFiltersShowMoreLabel": "より多く表示させるにはフィルターを変更します。",
-    "xpack.upgradeAssistant.checkupTab.controls.collapseAllButtonLabel": "すべて縮小",
-    "xpack.upgradeAssistant.checkupTab.controls.expandAllButtonLabel": "すべて拡張",
     "xpack.upgradeAssistant.checkupTab.controls.filterBar.criticalButtonLabel": "致命的",
-    "xpack.upgradeAssistant.checkupTab.controls.filterErrorMessageLabel": "フィルター無効：{searchTermError}",
     "xpack.upgradeAssistant.checkupTab.controls.groupByBar.byIndexLabel": "インデックス別",
     "xpack.upgradeAssistant.checkupTab.controls.groupByBar.byIssueLabel": "問題別",
-    "xpack.upgradeAssistant.checkupTab.controls.refreshButtonLabel": "更新",
-    "xpack.upgradeAssistant.checkupTab.controls.searchBarPlaceholder": "フィルター",
-    "xpack.upgradeAssistant.checkupTab.controls.searchBarPlaceholderAriaLabel": "フィルター",
     "xpack.upgradeAssistant.checkupTab.deprecations.criticalActionTooltip": "アップグレード前にこの問題を解決してください。",
     "xpack.upgradeAssistant.checkupTab.deprecations.criticalLabel": "致命的",
     "xpack.upgradeAssistant.checkupTab.deprecations.documentationButtonLabel": "ドキュメント",
@@ -22128,9 +22122,6 @@
     "xpack.upgradeAssistant.checkupTab.deprecations.warningActionTooltip": "アップグレード前にこの問題を解決することをお勧めしますが、必須ではありません。",
     "xpack.upgradeAssistant.checkupTab.deprecations.warningLabel": "警告",
     "xpack.upgradeAssistant.checkupTab.noDeprecationsLabel": "説明がありません",
-    "xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail": "{overviewTabButton} で次のステップを確認してください。",
-    "xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail.overviewTabButtonLabel": "概要タブ",
-    "xpack.upgradeAssistant.checkupTab.noIssues.noIssuesTitle": "完璧です！",
     "xpack.upgradeAssistant.checkupTab.numDeprecationsShownLabel": "{total} 件中 {numShown} 件を表示中",
     "xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.cancelButtonLabel": "キャンセル",
     "xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.closeButtonLabel": "閉じる",

diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json
@@ -22462,15 +22462,9 @@
     "xpack.uiActionsEnhanced.drilldowns.urlDrilldownValidation.urlFormatGeneralErrorMessage": "格式无效。例如：{exampleUrl}",
     "xpack.upgradeAssistant.appTitle": "{version} 升级助手",
     "xpack.upgradeAssistant.checkupTab.changeFiltersShowMoreLabel": "更改筛选以显示更多内容。",
-    "xpack.upgradeAssistant.checkupTab.controls.collapseAllButtonLabel": "折叠全部",
-    "xpack.upgradeAssistant.checkupTab.controls.expandAllButtonLabel": "展开全部",
     "xpack.upgradeAssistant.checkupTab.controls.filterBar.criticalButtonLabel": "紧急",
-    "xpack.upgradeAssistant.checkupTab.controls.filterErrorMessageLabel": "筛选无效：{searchTermError}",
     "xpack.upgradeAssistant.checkupTab.controls.groupByBar.byIndexLabel": "按索引",
     "xpack.upgradeAssistant.checkupTab.controls.groupByBar.byIssueLabel": "按问题",
-    "xpack.upgradeAssistant.checkupTab.controls.refreshButtonLabel": "刷新",
-    "xpack.upgradeAssistant.checkupTab.controls.searchBarPlaceholder": "筛选",
-    "xpack.upgradeAssistant.checkupTab.controls.searchBarPlaceholderAriaLabel": "筛选",
     "xpack.upgradeAssistant.checkupTab.deprecations.criticalActionTooltip": "请解决此问题后再升级。",
     "xpack.upgradeAssistant.checkupTab.deprecations.criticalLabel": "紧急",
     "xpack.upgradeAssistant.checkupTab.deprecations.documentationButtonLabel": "文档",
@@ -22480,9 +22474,6 @@
     "xpack.upgradeAssistant.checkupTab.deprecations.warningLabel": "警告",
     "xpack.upgradeAssistant.checkupTab.indicesBadgeLabel": "{numIndices, plural, other { 个索引}}",
     "xpack.upgradeAssistant.checkupTab.noDeprecationsLabel": "无弃用内容",
-    "xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail": "选中 {overviewTabButton} 以执行后续步骤。",
-    "xpack.upgradeAssistant.checkupTab.noIssues.nextStepsDetail.overviewTabButtonLabel": "“概述”选项卡",
-    "xpack.upgradeAssistant.checkupTab.noIssues.noIssuesTitle": "全部清除！",
     "xpack.upgradeAssistant.checkupTab.numDeprecationsShownLabel": "显示 {numShown} 个，共 {total} 个",
     "xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.cancelButtonLabel": "取消",
     "xpack.upgradeAssistant.checkupTab.reindexing.flyout.checklistStep.closeButtonLabel": "关闭",

diff --git a/x-pack/plugins/upgrade_assistant/common/types.ts b/x-pack/plugins/upgrade_assistant/common/types.ts
@@ -117,13 +117,14 @@ export enum IndexGroup {
 // Telemetry types
 export const UPGRADE_ASSISTANT_TYPE = 'upgrade-assistant-telemetry';
 export const UPGRADE_ASSISTANT_DOC_ID = 'upgrade-assistant-telemetry';
-export type UIOpenOption = 'overview' | 'cluster' | 'indices';
+export type UIOpenOption = 'overview' | 'cluster' | 'indices' | 'kibana';
 export type UIReindexOption = 'close' | 'open' | 'start' | 'stop';
 
 export interface UIOpen {
   overview: boolean;
   cluster: boolean;
   indices: boolean;
+  kibana: boolean;
 }
 
 export interface UIReindex {
@@ -138,6 +139,7 @@ export interface UpgradeAssistantTelemetrySavedObject {
     overview: number;
     cluster: number;
     indices: number;
+    kibana: number;
   };
   ui_reindex: {
     close: number;
@@ -152,6 +154,7 @@ export interface UpgradeAssistantTelemetry {
     overview: number;
     cluster: number;
     indices: number;
+    kibana: number;
   };
   ui_reindex: {
     close: number;

diff --git a/x-pack/plugins/upgrade_assistant/public/application/app.tsx b/x-pack/plugins/upgrade_assistant/public/application/app.tsx
@@ -11,6 +11,7 @@ import { I18nStart, ScopedHistory } from 'src/core/public';
 import { AppContextProvider, ContextValue, useAppContext } from './app_context';
 import { ComingSoonPrompt } from './components/coming_soon_prompt';
 import { EsDeprecationsContent } from './components/es_deprecations';
+import { KibanaDeprecationsContent } from './components/kibana_deprecations';
 import { DeprecationsOverview } from './components/overview';
 
 export interface AppDependencies extends ContextValue {
@@ -30,6 +31,7 @@ const App: React.FunctionComponent = () => {
     <Switch>
       <Route exact path="/overview" component={DeprecationsOverview} />
       <Route exact path="/es_deprecations/:tabName" component={EsDeprecationsContent} />
+      <Route exact path="/kibana_deprecations" component={KibanaDeprecationsContent} />
       <Redirect from="/" to="/overview" />
     </Switch>
   );

diff --git a/x-pack/plugins/upgrade_assistant/public/application/app_context.tsx b/x-pack/plugins/upgrade_assistant/public/application/app_context.tsx
@@ -5,7 +5,13 @@
  * 2.0.
  */
 
-import { CoreStart, DocLinksStart, HttpSetup, NotificationsStart } from 'src/core/public';
+import {
+  CoreStart,
+  DeprecationsServiceStart,
+  DocLinksStart,
+  HttpSetup,
+  NotificationsStart,
+} from 'src/core/public';
 import React, { createContext, useContext } from 'react';
 import { ApiService } from './lib/api';
 import { BreadcrumbService } from './lib/breadcrumbs';
@@ -26,6 +32,7 @@ export interface ContextValue {
   api: ApiService;
   breadcrumbs: BreadcrumbService;
   getUrlForApp: CoreStart['application']['getUrlForApp'];
+  deprecations: DeprecationsServiceStart;
 }
 
 export const AppContext = createContext<ContextValue>({} as any);

diff --git a/.../components/es_deprecations/constants.tsx → ...blic/application/components/constants.tsx b/.../components/es_deprecations/constants.tsx → ...blic/application/components/constants.tsx
@@ -7,7 +7,7 @@
 
 import { IconColor } from '@elastic/eui';
 import { invert } from 'lodash';
-import { DeprecationInfo } from '../../../../common/types';
+import { DeprecationInfo } from '../../../common/types';
 
 export const LEVEL_MAP: { [level: string]: number } = {
   warning: 0,
@@ -24,3 +24,5 @@ export const COLOR_MAP: { [level: string]: IconColor } = {
   warning: 'default',
   critical: 'danger',
 };
+
+export const DEPRECATIONS_PER_PAGE = 25;
diff --git a/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/controls.tsx b/x-pack/plugins/upgrade_assistant/public/application/components/es_deprecations/controls.tsx