add tests

elastic · Aug 28, 2023 · 93cfcd9 · 93cfcd9
1 parent 3de63d4
commit 93cfcd9
Show file tree

Hide file tree

Showing 3 changed files with 49 additions and 2 deletions.
diff --git a/...x_management/__jest__/client_integration/index_details_page/index_details_page.helpers.ts b/...x_management/__jest__/client_integration/index_details_page/index_details_page.helpers.ts
@@ -51,6 +51,10 @@ export interface IndexDetailsPageTestBed extends TestBed {
       isDisplayed: () => boolean;
       clickReloadButton: () => Promise<void>;
     };
+    statsTab: {
+      indexStatsContentExists: () => boolean;
+      indexStatsTabExists: () => boolean;
+    };
   };
 }
 
@@ -135,6 +139,15 @@ export const setup = async (
       component.update();
     },
   };
+
+  const statsTab = {
+    indexStatsContentExists: () => {
+      return exists('statsTabContent');
+    },
+    indexStatsTabExists: () => {
+      return exists('indexDetailsTab-stats');
+    },
+  };
   return {
     ...testBed,
     routerMock,
@@ -146,6 +159,7 @@ export const setup = async (
       discoverLinkExists,
       contextMenu,
       errorSection,
+      statsTab,
     },
   };
 };
diff --git a/...ndex_management/__jest__/client_integration/index_details_page/index_details_page.test.ts b/...ndex_management/__jest__/client_integration/index_details_page/index_details_page.test.ts
@@ -60,6 +60,39 @@ describe('<IndexDetailsPage />', () => {
     });
   });
 
+  describe('Stats tab', () => {
+    it('loads index stats from the API', async () => {
+      const numberOfRequests = 1;
+      // Expect initial request to fetch index details
+      expect(httpSetup.get).toHaveBeenCalledTimes(numberOfRequests);
+
+      await testBed.actions.clickIndexDetailsTab(IndexDetailsSection.Stats);
+      expect(httpSetup.get).toHaveBeenLastCalledWith(`${API_BASE_PATH}/stats/${testIndexName}`, {
+        asSystemRequest: undefined,
+        body: undefined,
+        query: undefined,
+        version: undefined,
+      });
+      expect(httpSetup.get).toHaveBeenCalledTimes(numberOfRequests + 1);
+    });
+
+    it('renders index stats', async () => {
+      await testBed.actions.clickIndexDetailsTab(IndexDetailsSection.Stats);
+      expect(testBed.actions.statsTab.indexStatsContentExists()).toBe(true);
+    });
+
+    it('hides index stats tab if enableIndexStats===false', async () => {
+      await act(async () => {
+        testBed = await setup(httpSetup, {
+          config: { enableIndexStats: false },
+        });
+      });
+      testBed.component.update();
+
+      expect(testBed.actions.statsTab.indexStatsTabExists()).toBe(false);
+    });
+  });
+
   it('loads index details from the API', async () => {
     expect(httpSetup.get).toHaveBeenLastCalledWith(
       `${INTERNAL_API_BASE_PATH}/indices/${testIndexName}`,

diff --git a/.../index_management/public/application/sections/home/index_list/details_page/tabs/stats.tsx b/.../index_management/public/application/sections/home/index_list/details_page/tabs/stats.tsx
@@ -88,7 +88,7 @@ export const StatsTab: React.FunctionComponent<Props> = ({ indexName }) => {
 
   if (indexStats) {
     return (
-      <EuiFlexGroup alignItems="flexStart">
+      <EuiFlexGroup alignItems="flexStart" data-test-subj="statsTabContent">
         <EuiFlexItem grow={7}>
           <EuiPanel>
             <EuiCodeBlock isCopyable language="json" fontSize="m" paddingSize="m">
@@ -120,7 +120,7 @@ export const StatsTab: React.FunctionComponent<Props> = ({ indexName }) => {
               <p>
                 <FormattedMessage
                   id="xpack.idxMgmt.indexDetails.indexStatsTab.indexStatsDescription"
-                  defaultMessage="Index stats contains high-level aggregation and statistics for an index. The {primariesField} field represents the values for only primary shards, while the {totalField} field contains the accumulated values for both primary and replica shards."
+                  defaultMessage="Index stats contain high-level aggregation and statistics for an index. The {primariesField} field represents the values for only primary shards, while the {totalField} field contains the accumulated values for both primary and replica shards."
                   values={{
                     primariesField: <EuiCode>primaries</EuiCode>,
                     totalField: <EuiCode>total</EuiCode>,