fixes

elastic · Sep 29, 2020 · 9453941 · 9453941
1 parent 436f977
commit 9453941
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 12 deletions.
diff --git a/src/plugins/expressions/common/expression_types/specs/datatable.ts b/src/plugins/expressions/common/expression_types/specs/datatable.ts
@@ -41,6 +41,7 @@ export const isDatatable = (datatable: unknown): datatable is Datatable =>
 
 /**
  * This type represents the `type` of any `DatatableColumn` in a `Datatable`.
+ * its duplicated from KBN_FIELD_TYPES
  */
 export type DatatableColumnType =
   | '_source'

diff --git a/test/functional/apps/dashboard/index.js b/test/functional/apps/dashboard/index.js
@@ -48,7 +48,7 @@ export default function ({ getService, loadTestFile }) {
       before(loadCurrentData);
       after(unloadCurrentData);
 
-      // loadTestFile(require.resolve('./empty_dashboard'));
+      loadTestFile(require.resolve('./empty_dashboard'));
       loadTestFile(require.resolve('./url_field_formatter'));
       loadTestFile(require.resolve('./embeddable_rendering'));
       loadTestFile(require.resolve('./create_and_add_embeddables'));

diff --git a/test/functional/config.js b/test/functional/config.js
@@ -25,18 +25,18 @@ export default async function ({ readConfigFile }) {
 
   return {
     testFiles: [
-      // require.resolve('./apps/bundles'),
-      // require.resolve('./apps/console'),
-      // require.resolve('./apps/context'),
+      require.resolve('./apps/bundles'),
+      require.resolve('./apps/console'),
+      require.resolve('./apps/context'),
       require.resolve('./apps/dashboard'),
-      // require.resolve('./apps/discover'),
-      // require.resolve('./apps/getting_started'),
-      // require.resolve('./apps/home'),
-      // require.resolve('./apps/management'),
-      // require.resolve('./apps/saved_objects_management'),
-      // require.resolve('./apps/status_page'),
-      // require.resolve('./apps/timelion'),
-      // require.resolve('./apps/visualize'),
+      require.resolve('./apps/discover'),
+      require.resolve('./apps/getting_started'),
+      require.resolve('./apps/home'),
+      require.resolve('./apps/management'),
+      require.resolve('./apps/saved_objects_management'),
+      require.resolve('./apps/status_page'),
+      require.resolve('./apps/timelion'),
+      require.resolve('./apps/visualize'),
     ],
     pageObjects,
     services,