Add E2E tests

elastic · Dec 1, 2023 · 96b9c50 · 96b9c50
1 parent 697e1e4
commit 96b9c50
Show file tree

Hide file tree

Showing 6 changed files with 631 additions and 217 deletions.
diff --git a/x-pack/plugins/alerting/server/task_runner/task_runner.ts b/x-pack/plugins/alerting/server/task_runner/task_runner.ts
@@ -434,9 +434,6 @@ export class TaskRunner<
       return false;
     });
 
-    const maintenanceWindowsWithScopedQuery = maintenanceWindows.filter(
-      ({ scopedQuery }) => scopedQuery
-    );
     const maintenanceWindowsWithoutScopedQuery = maintenanceWindows.filter(
       ({ scopedQuery }) => !scopedQuery
     );
@@ -598,7 +595,7 @@ export class TaskRunner<
           ruleId: rule.id,
           spaceId,
           executionUuid: this.executionId,
-          maintenanceWindows: maintenanceWindowsWithScopedQuery,
+          maintenanceWindows,
         });
     } catch (e) {
       this.logger.debug(

diff --git a/x-pack/test/alerting_api_integration/common/plugins/alerts/server/alert_types.ts b/x-pack/test/alerting_api_integration/common/plugins/alerts/server/alert_types.ts
@@ -552,7 +552,7 @@ function getPatternFiringAlertsAsDataRuleType() {
     id: 'test.patternFiringAad',
     name: 'Test: Firing on a Pattern and writing Alerts as Data',
     actionGroups: [{ id: 'default', name: 'Default' }],
-    category: 'kibana',
+    category: 'management',
     producer: 'alertsFixture',
     defaultActionGroupId: 'default',
     minimumLicenseRequired: 'basic',

diff --git a/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/index.ts b/x-pack/test/alerting_api_integration/spaces_only/tests/alerting/group3/index.ts
@@ -16,5 +16,6 @@ export default function alertingTests({ loadTestFile, getService }: FtrProviderC
 
     loadTestFile(require.resolve('./builtin_alert_types'));
     loadTestFile(require.resolve('./maintenance_window_flows'));
+    loadTestFile(require.resolve('./maintenance_window_scoped_query'));
   });
 }