restore index pattern management data-test-subj's (#64697)

* restore index pattern management data-test-subj's
elastic · May 8, 2020 · 97561d6 · 97561d6
1 parent 3a6c1ce
commit 97561d6
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/...plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/tabs/utils.ts b/...plugins/kibana/public/management/sections/index_patterns/edit_index_pattern/tabs/utils.ts
@@ -96,18 +96,21 @@ export function getTabs(
   tabs.push({
     name: getTitle('indexed', filteredCount, totalCount),
     id: TAB_INDEXED_FIELDS,
+    'data-test-subj': 'tab-indexedFields',
   });
 
   if (indexPatternListProvider.areScriptedFieldsEnabled(indexPattern)) {
     tabs.push({
       name: getTitle('scripted', filteredCount, totalCount),
       id: TAB_SCRIPTED_FIELDS,
+      'data-test-subj': 'tab-scriptedFields',
     });
   }
 
   tabs.push({
     name: getTitle('sourceFilters', filteredCount, totalCount),
     id: TAB_SOURCE_FILTERS,
+    'data-test-subj': 'tab-sourceFilters',
   });
 
   return tabs;

diff --git a/test/functional/page_objects/settings_page.ts b/test/functional/page_objects/settings_page.ts
@@ -206,17 +206,15 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
 
     async getFieldsTabCount() {
       return retry.try(async () => {
-        const indexedFieldsTab = await find.byCssSelector('#indexedFields .euiTab__content');
-        const text = await indexedFieldsTab.getVisibleText();
-        return text.split(/[()]/)[1];
+        const text = await testSubjects.getVisibleText('tab-indexedFields');
+        return text.split(' ')[1].replace(/\((.*)\)/, '$1');
       });
     }
 
     async getScriptedFieldsTabCount() {
       return await retry.try(async () => {
-        const scriptedFieldsTab = await find.byCssSelector('#scriptedFields .euiTab__content');
-        const text = await scriptedFieldsTab.getVisibleText();
-        return text.split(/[()]/)[1];
+        const text = await testSubjects.getVisibleText('tab-scriptedFields');
+        return text.split(' ')[2].replace(/\((.*)\)/, '$1');
       });
     }
 
@@ -431,17 +429,17 @@ export function SettingsPageProvider({ getService, getPageObjects }: FtrProvider
 
     async clickFieldsTab() {
       log.debug('click Fields tab');
-      await find.clickByCssSelector('#indexedFields');
+      await testSubjects.click('tab-indexedFields');
     }
 
     async clickScriptedFieldsTab() {
       log.debug('click Scripted Fields tab');
-      await find.clickByCssSelector('#scriptedFields');
+      await testSubjects.click('tab-scriptedFields');
     }
 
     async clickSourceFiltersTab() {
       log.debug('click Source Filters tab');
-      await find.clickByCssSelector('#sourceFilters');
+      await testSubjects.click('tab-sourceFilters');
     }
 
     async editScriptedField(name: string) {