moving check inside getCloudMetadata

elastic · Nov 18, 2020 · 97a885f · 97a885f
1 parent eafc72b
commit 97a885f
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/x-pack/plugins/infra/server/routes/inventory_metadata/index.ts b/x-pack/plugins/infra/server/routes/inventory_metadata/index.ts
@@ -39,19 +39,6 @@ export const initInventoryMetaRoute = (libs: InfraBackendLibs) => {
           fold(throwErrors(Boom.badRequest), identity)
         );
 
-        const model = findInventoryModel(nodeType);
-
-        // Only run this for AWS modules, eventually we might have more.
-        if (model.requiredModule !== 'aws') {
-          return response.ok({
-            body: {
-              accounts: [],
-              projects: [],
-              regions: [],
-            },
-          });
-        }
-
         const { configuration } = await libs.sources.getSourceConfiguration(
           requestContext.core.savedObjects.client,
           sourceId

diff --git a/x-pack/plugins/infra/server/routes/inventory_metadata/lib/get_cloud_metadata.ts b/x-pack/plugins/infra/server/routes/inventory_metadata/lib/get_cloud_metadata.ts
@@ -29,6 +29,14 @@ export const getCloudMetadata = async (
   currentTime: number
 ): Promise<CloudMetaData> => {
   const model = findInventoryModel(nodeType);
+  // Only run this for AWS modules, eventually we might have more.
+  if (model.requiredModule !== 'aws') {
+    return {
+      accounts: [],
+      projects: [],
+      regions: [],
+    };
+  }
 
   const metricQuery = {
     allowNoIndices: true,