[7.x] [dev-utils/ship-ci-stats] fail when CI stats is down (#90678) (#…

…90706) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Spencer <email@spalger.com> Co-authored-by: spalger <spalger@users.noreply.github.com>
elastic · Feb 9, 2021 · 99299e0 · 99299e0
1 parent 8ddbaba
commit 99299e0
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/packages/kbn-dev-utils/src/ci_stats_reporter/ci_stats_reporter.ts b/packages/kbn-dev-utils/src/ci_stats_reporter/ci_stats_reporter.ts
@@ -109,7 +109,7 @@ export class CiStatsReporter {
           },
         });
 
-        return;
+        return true;
       } catch (error) {
         if (!error?.request) {
           // not an axios error, must be a usage error that we should notify user about

diff --git a/packages/kbn-dev-utils/src/ci_stats_reporter/ship_ci_stats_cli.ts b/packages/kbn-dev-utils/src/ci_stats_reporter/ship_ci_stats_cli.ts
@@ -10,7 +10,7 @@ import Path from 'path';
 import Fs from 'fs';
 
 import { CiStatsReporter } from './ci_stats_reporter';
-import { run, createFlagError } from '../run';
+import { run, createFlagError, createFailError } from '../run';
 
 export function shipCiStatsCli() {
   run(
@@ -23,12 +23,20 @@ export function shipCiStatsCli() {
       }
 
       const reporter = CiStatsReporter.fromEnv(log);
+
+      if (!reporter.isEnabled()) {
+        throw createFailError('unable to initilize the CI Stats reporter');
+      }
+
       for (const path of metricPaths) {
         // resolve path from CLI relative to CWD
         const abs = Path.resolve(path);
         const json = Fs.readFileSync(abs, 'utf8');
-        await reporter.metrics(JSON.parse(json));
-        log.success('shipped metrics from', path);
+        if (await reporter.metrics(JSON.parse(json))) {
+          log.success('shipped metrics from', path);
+        } else {
+          throw createFailError('failed to ship metrics');
+        }
       }
     },
     {