[ML] tests

elastic · May 12, 2020 · a4e75f7 · a4e75f7
1 parent 3c86922
commit a4e75f7
Show file tree

Hide file tree

Showing 4 changed files with 396 additions and 4 deletions.
diff --git a/x-pack/plugins/ml/server/models/job_validation/validate_bucket_span.js b/x-pack/plugins/ml/server/models/job_validation/validate_bucket_span.js
@@ -65,7 +65,7 @@ export async function validateBucketSpan(
   }
 
   const messages = [];
-  const parsedBucketSpan = parseInterval(job.analysis_config.bucket_span, false);
+  const parsedBucketSpan = parseInterval(job.analysis_config.bucket_span);
   if (parsedBucketSpan === null || parsedBucketSpan.asMilliseconds() === 0) {
     messages.push({ id: 'bucket_span_invalid' });
     return messages;

diff --git a/x-pack/test/api_integration/apis/ml/anomaly_detectors/get.ts b/x-pack/test/api_integration/apis/ml/anomaly_detectors/get.ts
@@ -145,7 +145,7 @@ export default ({ getService }: FtrProviderContext) => {
         expect(body.count).to.eql(2);
         expect(body.jobs.length).to.eql(2);
         expect(body.jobs[0].job_id).to.eql(`${jobId}_1`);
-        expect(body.jobs[0]).to.keys(
+        expect(body.jobs[0]).to.have.keys(
           'timing_stats',
           'state',
           'forecasts_stats',
@@ -178,7 +178,7 @@ export default ({ getService }: FtrProviderContext) => {
         expect(body.count).to.eql(1);
         expect(body.jobs.length).to.eql(1);
         expect(body.jobs[0].job_id).to.eql(`${jobId}_1`);
-        expect(body.jobs[0]).to.keys(
+        expect(body.jobs[0]).to.have.keys(
           'timing_stats',
           'state',
           'forecasts_stats',
@@ -197,7 +197,7 @@ export default ({ getService }: FtrProviderContext) => {
         expect(body.count).to.eql(2);
         expect(body.jobs.length).to.eql(2);
         expect(body.jobs[0].job_id).to.eql(`${jobId}_1`);
-        expect(body.jobs[0]).to.keys(
+        expect(body.jobs[0]).to.have.keys(
           'timing_stats',
           'state',
           'forecasts_stats',

diff --git a/x-pack/test/api_integration/apis/ml/job_validation/index.ts b/x-pack/test/api_integration/apis/ml/job_validation/index.ts
@@ -10,5 +10,6 @@ export default function({ loadTestFile }: FtrProviderContext) {
     loadTestFile(require.resolve('./bucket_span_estimator'));
     loadTestFile(require.resolve('./calculate_model_memory_limit'));
     loadTestFile(require.resolve('./cardinality'));
+    loadTestFile(require.resolve('./validate'));
   });
 }