Removing the setTimeout code to simplify to a for/of

elastic · Dec 23, 2021 · a691f9c · a691f9c
1 parent 30cffea
commit a691f9c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 32 deletions.
diff --git a/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/do_work.ts b/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/do_work.ts
diff --git a/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_rule.ts b/x-pack/plugins/infra/server/lib/alerting/metric_threshold/lib/evaluate_rule.ts
@@ -22,7 +22,6 @@ import { UNGROUPED_FACTORY_KEY } from '../../common/utils';
 import { MetricExpressionParams, Comparator, Aggregators } from '../types';
 import { getElasticsearchMetricQuery } from './metric_query';
 import { createTimerange } from './create_timerange';
-import { doWork } from './do_work';
 
 interface AggregationWithoutIntervals {
   aggregatedValue: { value: number; values?: Array<{ key: number; value: number }> };
@@ -204,23 +203,17 @@ const getMetric: (
         afterKeyHandler
       )) as Array<Aggregation & { key: Record<string, string>; doc_count: number }>;
       const groupedResults: Record<string, any> = {};
-      await Promise.all(
-        compositeBuckets.map((bucket) => {
-          return doWork(() => {
-            const key = Object.values(bucket.key)
-              .map((value) => value)
-              .join(', ');
-            const value = getValuesFromAggregations(
-              bucket,
-              aggType,
-              dropPartialBucketsOptions,
-              calculatedTimerange,
-              bucket.doc_count
-            );
-            groupedResults[key] = value;
-          });
-        })
-      );
+      for (const bucket of compositeBuckets) {
+        const key = Object.values(bucket.key).join(', ');
+        const value = getValuesFromAggregations(
+          bucket,
+          aggType,
+          dropPartialBucketsOptions,
+          calculatedTimerange,
+          bucket.doc_count
+        );
+        groupedResults[key] = value;
+      }
       return groupedResults;
     }
     const { body: result } = await esClient.search({