resultsField: check for only spaces string in editor and form

elastic · Jul 7, 2020 · ba0dede · ba0dede
1 parent 4128e0c
commit ba0dede
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 4 deletions.
diff --git a/...frame_analytics/pages/analytics_creation/components/details_step/details_step_details.tsx b/...frame_analytics/pages/analytics_creation/components/details_step/details_step_details.tsx
@@ -16,6 +16,8 @@ import {
 import { State } from '../../../analytics_management/hooks/use_create_analytics_form/state';
 import { ANALYTICS_STEPS } from '../../page';
 
+const DEFAULT_RESULTS_FIELD = 'ml';
+
 export interface ListItems {
   title: string;
   description: string | JSX.Element;
@@ -26,7 +28,7 @@ export const DetailsStepDetails: FC<{ setCurrentStep: any; state: State }> = ({
   state,
 }) => {
   const { form, isJobCreated } = state;
-  const { description, jobId, destinationIndex } = form;
+  const { description, jobId, destinationIndex, resultsField } = form;
 
   const detailsFirstCol: ListItems[] = [
     {
@@ -37,6 +39,19 @@ export const DetailsStepDetails: FC<{ setCurrentStep: any; state: State }> = ({
     },
   ];
 
+  if (
+    resultsField !== undefined &&
+    typeof resultsField === 'string' &&
+    resultsField.trim() !== ''
+  ) {
+    detailsFirstCol.push({
+      title: i18n.translate('xpack.ml.dataframe.analytics.create.configDetails.resultsField', {
+        defaultMessage: 'Results field',
+      }),
+      description: resultsField,
+    });
+  }
+
   const detailsSecondCol: ListItems[] = [
     {
       title: i18n.translate('xpack.ml.dataframe.analytics.create.configDetails.jobDescription', {

diff --git a/...analytics/pages/analytics_exploration/components/regression_exploration/evaluate_stat.tsx b/...analytics/pages/analytics_exploration/components/regression_exploration/evaluate_stat.tsx
@@ -45,8 +45,11 @@ const statDescriptions = {
           <EuiLink
             href="https://en.wikipedia.org/wiki/Huber_loss#Pseudo-Huber_loss_function"
             target="_blank"
+            external
           >
-            Pseudo Huber loss function
+            {i18n.translate('xpack.ml.dataframe.analytics.regressionExploration.huberLinkText', {
+              defaultMessage: 'Pseudo Huber loss function',
+            })}
           </EuiLink>
         ),
       }}

diff --git a/...ata_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/reducer.ts b/...ata_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/reducer.ts
@@ -145,7 +145,9 @@ export const validateAdvancedEditor = (state: State): State => {
   const destinationIndexPatternTitleExists =
     state.indexPatternsMap[destinationIndexName] !== undefined;
 
-  const resultsFieldEmptyString = jobConfig?.dest?.results_field === '';
+  const resultsFieldEmptyString =
+    typeof jobConfig?.dest?.results_field === 'string' &&
+    jobConfig?.dest?.results_field.trim() === '';
 
   const mml = jobConfig.model_memory_limit;
   const modelMemoryLimitEmpty = mml === '' || mml === undefined;

diff --git a/.../data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts b/.../data_frame_analytics/pages/analytics_management/hooks/use_create_analytics_form/state.ts
@@ -200,7 +200,10 @@ export const getJobConfigFromFormState = (
     model_memory_limit: formState.modelMemoryLimit,
   };
 
-  if (jobConfig.dest && (formState.resultsField !== undefined || formState.resultsField !== '')) {
+  const resultsFieldEmpty =
+    typeof formState?.resultsField === 'string' && formState?.resultsField.trim() === '';
+
+  if (jobConfig.dest && !resultsFieldEmpty) {
     jobConfig.dest.results_field = formState.resultsField;
   }