[Lens] Fix unintentional switching to pie (#93219)

elastic · Mar 3, 2021 · c42b994 · c42b994
1 parent 529624d
commit c42b994
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 7 deletions.
diff --git a/x-pack/plugins/lens/public/pie_visualization/visualization.test.ts b/x-pack/plugins/lens/public/pie_visualization/visualization.test.ts
@@ -17,7 +17,7 @@ const pieVisualization = getPieVisualization({
   paletteService: chartPluginMock.createPaletteRegistry(),
 });
 
-function exampleState(): PieVisualizationState {
+function getExampleState(): PieVisualizationState {
   return {
     shape: 'pie',
     layers: [
@@ -38,9 +38,39 @@ function exampleState(): PieVisualizationState {
 describe('pie_visualization', () => {
   describe('#getErrorMessages', () => {
     it('returns undefined if no error is raised', () => {
-      const error = pieVisualization.getErrorMessages(exampleState());
+      const error = pieVisualization.getErrorMessages(getExampleState());
 
       expect(error).not.toBeDefined();
     });
   });
+  describe('#setDimension', () => {
+    it('returns expected state', () => {
+      const prevState: PieVisualizationState = {
+        layers: [
+          {
+            groups: ['a'],
+            layerId: LAYER_ID,
+            numberDisplay: 'percent',
+            categoryDisplay: 'default',
+            legendDisplay: 'default',
+            nestedLegend: false,
+            metric: undefined,
+          },
+        ],
+        shape: 'donut',
+      };
+      const setDimensionResult = pieVisualization.setDimension({
+        prevState,
+        columnId: 'x',
+        layerId: LAYER_ID,
+        groupId: 'a',
+      });
+
+      expect(setDimensionResult).toEqual(
+        expect.objectContaining({
+          shape: 'donut',
+        })
+      );
+    });
+  });
 });
diff --git a/x-pack/plugins/lens/public/pie_visualization/visualization.tsx b/x-pack/plugins/lens/public/pie_visualization/visualization.tsx
@@ -196,11 +196,6 @@ export const getPieVisualization = ({
   setDimension({ prevState, layerId, columnId, groupId }) {
     return {
       ...prevState,
-
-      shape:
-        prevState.shape === 'donut' && prevState.layers.every((l) => l.groups.length === 1)
-          ? 'pie'
-          : prevState.shape,
       layers: prevState.layers.map((l) => {
         if (l.layerId !== layerId) {
           return l;