- resets the selected index

elastic · Apr 24, 2023 · cdf6f2e · cdf6f2e
1 parent d4f9e8e
commit cdf6f2e
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 5 deletions.
diff --git a/...uality-dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.tsx b/...uality-dashboard/impl/data_quality/data_quality_panel/body/data_quality_details/index.tsx
@@ -111,6 +111,7 @@ const DataQualityDetailsComponent: React.FC<Props> = ({
         patternIndexNames={patternIndexNames}
         patternRollups={patternRollups}
         selectedIndex={selectedIndex}
+        setSelectedIndex={setSelectedIndex}
         updatePatternIndexNames={updatePatternIndexNames}
         updatePatternRollup={updatePatternRollup}
       />

diff --git a/.../data_quality/data_quality_panel/body/data_quality_details/indices_details/index.test.tsx b/.../data_quality/data_quality_panel/body/data_quality_details/indices_details/index.test.tsx
@@ -60,6 +60,7 @@ const defaultProps: Props = {
   patternRollups,
   patterns,
   selectedIndex: null,
+  setSelectedIndex: jest.fn(),
   theme: DARK_THEME,
   updatePatternIndexNames: jest.fn(),
   updatePatternRollup: jest.fn(),

diff --git a/.../impl/data_quality/data_quality_panel/body/data_quality_details/indices_details/index.tsx b/.../impl/data_quality/data_quality_panel/body/data_quality_details/indices_details/index.tsx
@@ -50,6 +50,7 @@ export interface Props {
   patternRollups: Record<string, PatternRollup>;
   patterns: string[];
   selectedIndex: SelectedIndex | null;
+  setSelectedIndex: (selectedIndex: SelectedIndex | null) => void;
   theme: Theme;
   updatePatternIndexNames: ({
     indexNames,
@@ -73,6 +74,7 @@ const IndicesDetailsComponent: React.FC<Props> = ({
   patternRollups,
   patterns,
   selectedIndex,
+  setSelectedIndex,
   theme,
   updatePatternIndexNames,
   updatePatternRollup,
@@ -92,6 +94,7 @@ const IndicesDetailsComponent: React.FC<Props> = ({
           pattern={pattern}
           patternRollup={patternRollups[pattern]}
           selectedIndex={selectedIndex}
+          setSelectedIndex={setSelectedIndex}
           theme={theme}
           updatePatternIndexNames={updatePatternIndexNames}
           updatePatternRollup={updatePatternRollup}

diff --git a/...bn-ecs-data-quality-dashboard/impl/data_quality/data_quality_panel/pattern/index.test.tsx b/...bn-ecs-data-quality-dashboard/impl/data_quality/data_quality_panel/pattern/index.test.tsx
@@ -49,6 +49,7 @@ const defaultProps = {
   openCreateCaseFlyout: jest.fn(),
   patternRollup: undefined,
   selectedIndex: null,
+  setSelectedIndex: jest.fn(),
   theme: DARK_THEME,
   updatePatternIndexNames: jest.fn(),
   updatePatternRollup: jest.fn(),

diff --git a/...ges/kbn-ecs-data-quality-dashboard/impl/data_quality/data_quality_panel/pattern/index.tsx b/...ges/kbn-ecs-data-quality-dashboard/impl/data_quality/data_quality_panel/pattern/index.tsx
@@ -86,6 +86,7 @@ interface Props {
   pattern: string;
   patternRollup: PatternRollup | undefined;
   selectedIndex: SelectedIndex | null;
+  setSelectedIndex: (selectedIndex: SelectedIndex | null) => void;
   theme: Theme;
   updatePatternIndexNames: ({
     indexNames,
@@ -109,6 +110,7 @@ const PatternComponent: React.FC<Props> = ({
   pattern,
   patternRollup,
   selectedIndex,
+  setSelectedIndex,
   theme,
   updatePatternIndexNames,
   updatePatternRollup,
@@ -254,14 +256,22 @@ const PatternComponent: React.FC<Props> = ({
         setPageIndex(selectedPageIndex);
       }
 
-      // if the selected index is not expanded, expand it
       if (itemIdToExpandedRowMap[selectedIndex.indexName] == null) {
-        toggleExpanded(selectedIndex.indexName);
-
-        containerRef.current?.scrollIntoView();
+        toggleExpanded(selectedIndex.indexName); // expand the selected index
       }
+
+      containerRef.current?.scrollIntoView();
+      setSelectedIndex(null);
     }
-  }, [itemIdToExpandedRowMap, items, pageSize, pattern, selectedIndex, toggleExpanded]);
+  }, [
+    itemIdToExpandedRowMap,
+    items,
+    pageSize,
+    pattern,
+    selectedIndex,
+    setSelectedIndex,
+    toggleExpanded,
+  ]);
 
   return (
     <EuiPanel data-test-subj={`${pattern}PatternPanel`} hasBorder={false} hasShadow={false}>