address review feedback

elastic · Apr 8, 2020 · d6f862c · d6f862c
1 parent 664c6ad
commit d6f862c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 10 deletions.
diff --git a/x-pack/plugins/ingest_pipelines/common/lib/pipeline_serialization.ts b/x-pack/plugins/ingest_pipelines/common/lib/pipeline_serialization.ts
@@ -20,13 +20,7 @@ export function deserializePipelines(pipelinesByName: PipelinesByName): Pipeline
       onFailure: on_failure,
     };
 
-    // Remove any undefined values
-    return Object.entries(pipeline).reduce((pipelineDefinition: any, [key, value]) => {
-      if (value !== undefined) {
-        pipelineDefinition[key] = value;
-      }
-      return pipelineDefinition;
-    }, {});
+    return pipeline;
   });
 
   return deserializedPipelines;

diff --git a/x-pack/plugins/ingest_pipelines/server/routes/api/update.ts b/x-pack/plugins/ingest_pipelines/server/routes/api/update.ts
@@ -35,7 +35,7 @@ export const registerUpdateRoute = ({
     },
     license.guardApiRoute(async (ctx, req, res) => {
       const { callAsCurrentUser } = ctx.core.elasticsearch.dataClient;
-      const { name } = req.params as typeof paramsSchema.type;
+      const { name } = req.params;
       const pipeline = req.body as Pipeline;
 
       const { description, processors, version, onFailure } = pipeline;

diff --git a/x-pack/plugins/ingest_pipelines/server/services/license.ts b/x-pack/plugins/ingest_pipelines/server/services/license.ts
@@ -53,12 +53,12 @@ export class License {
     });
   }
 
-  guardApiRoute(handler: RequestHandler) {
+  guardApiRoute<P, Q, B>(handler: RequestHandler<P, Q, B>) {
     const license = this;
 
     return function licenseCheck(
       ctx: RequestHandlerContext,
-      request: KibanaRequest,
+      request: KibanaRequest<P, Q, B>,
       response: KibanaResponseFactory
     ) {
       const licenseStatus = license.getStatus();