registering vis alias in lens

elastic · Feb 26, 2020 · d92380e · d92380e
1 parent f0ba010
commit d92380e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/x-pack/legacy/plugins/lens/index.ts b/x-pack/legacy/plugins/lens/index.ts
@@ -33,7 +33,6 @@ export const lens: LegacyPluginInitializer = kibana => {
       embeddableFactories: [`plugins/${PLUGIN_ID}/legacy`],
       styleSheetPaths: resolve(__dirname, 'public/index.scss'),
       mappings,
-      hacks: ['plugins/lens/register_vis_type_alias'],
       savedObjectsManagement: {
         lens: {
           defaultSearchField: 'title',

diff --git a/x-pack/legacy/plugins/lens/public/plugin.tsx b/x-pack/legacy/plugins/lens/public/plugin.tsx
@@ -38,6 +38,8 @@ import {
 import { FormatFactory } from './legacy_imports';
 import { IEmbeddableSetup, IEmbeddableStart } from '../../../../../src/plugins/embeddable/public';
 import { EditorFrameStart } from './types';
+import { setup as visualizations } from '../../../../../src/legacy/core_plugins/visualizations/public/np_ready/public/legacy';
+import { getLensAliasConfig } from './vis_type_alias';
 
 export interface LensPluginSetupDependencies {
   kibanaLegacy: KibanaLegacySetup;
@@ -100,6 +102,8 @@ export class LensPlugin {
     this.datatableVisualization.setup(core, dependencies);
     this.metricVisualization.setup(core, dependencies);
 
+    visualizations.types.registerAlias(getLensAliasConfig());
+
     kibanaLegacy.registerLegacyApp({
       id: 'lens',
       title: NOT_INTERNATIONALIZED_PRODUCT_NAME,

diff --git a/...ns/lens/public/register_vis_type_alias.ts → ...acy/plugins/lens/public/vis_type_alias.ts b/...ns/lens/public/register_vis_type_alias.ts → ...acy/plugins/lens/public/vis_type_alias.ts
@@ -5,10 +5,9 @@
  */
 
 import { i18n } from '@kbn/i18n';
-import { setup as visualizations } from '../../../../../src/legacy/core_plugins/visualizations/public/np_ready/public/legacy';
 import { getBasePath, getEditPath } from '../../../../plugins/lens/common';
 
-visualizations.types.registerAlias({
+export const getLensAliasConfig = () => ({
   aliasUrl: getBasePath(),
   name: 'lens',
   promotion: {