[Uptime] Feature/expandable row in details ping list (#51890) (#53055)

* update columns * update expand row in ping list
elastic · Dec 15, 2019 · e0f682a · e0f682a
1 parent 29921e1
commit e0f682a
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 9 deletions.
diff --git a/...lic/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap b/...lic/components/functional/monitor_list/__tests__/__snapshots__/monitor_list.test.tsx.snap
diff --git a/...nts/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap b/...nts/functional/monitor_list/__tests__/__snapshots__/monitor_list_pagination.test.tsx.snap
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx b/x-pack/legacy/plugins/uptime/public/components/functional/monitor_list/monitor_list.tsx
@@ -208,7 +208,7 @@ export const MonitorListComponent = (props: Props) => {
               field: 'monitor_id',
               name: '',
               sortable: true,
-              width: '40px',
+              width: '24px',
               isExpander: true,
               render: (id: string) => {
                 return (

diff --git a/...me/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap b/...me/public/components/functional/ping_list/__tests__/__snapshots__/ping_list.test.tsx.snap
diff --git a/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx b/x-pack/legacy/plugins/uptime/public/components/functional/ping_list/ping_list.tsx
@@ -191,7 +191,7 @@ export const PingListComponent = ({
   if (hasStatus) {
     columns.push({
       field: 'http.response.status_code',
-      align: 'right',
+      align: 'center',
       name: i18n.translate('xpack.uptime.pingList.responseCodeColumnLabel', {
         defaultMessage: 'Response code',
       }),
@@ -201,7 +201,7 @@ export const PingListComponent = ({
 
   columns.push({
     align: 'right',
-    width: '40px',
+    width: '24px',
     isExpander: true,
     render: (item: Ping) => (
       <EuiButtonIcon
@@ -303,6 +303,8 @@ export const PingListComponent = ({
         <EuiBasicTable
           loading={loading}
           columns={columns}
+          isExpandable={true}
+          hasActions={true}
           items={pings}
           itemId="id"
           itemIdToExpandedRowMap={itemIdToExpandedRowMap}