Skip to content

Commit

Permalink
Rename variables for clarity
Browse files Browse the repository at this point in the history
  • Loading branch information
phillipb committed Feb 6, 2020
1 parent 91c7bfc commit e4d45b5
Showing 1 changed file with 9 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -39,31 +39,30 @@ const getGroupPaths = (path: SnapshotNodePath[]) => {

export const TableView = (props: Props) => {
const { nodes, options, formatter, currentTime, nodeType } = props;
const [isPopoverOpen, setIsPopoverOpen] = useState<string[]>([]);
const [openPopovers, setOpenPopovers] = useState<string[]>([]);
const openPopoverFor = useCallback(
(id: string) => () => {
setIsPopoverOpen([...isPopoverOpen, id]);
setOpenPopovers([...openPopovers, id]);
},
[isPopoverOpen]
[openPopovers]
);

const closePopoverFor = useCallback(
(id: string) => () => {
setIsPopoverOpen([...isPopoverOpen, id]);
if (isPopoverOpen.includes(id)) {
setIsPopoverOpen(isPopoverOpen.filter(subject => subject !== id));
if (openPopovers.includes(id)) {
setOpenPopovers(openPopovers.filter(subject => subject !== id));
}
},
[isPopoverOpen]
[openPopovers]
);

useEffect(() => {
if (isPopoverOpen.length > 0) {
if (openPopovers.length > 0) {
document.getElementById(ROOT_ELEMENT_ID)!.style.overflowY = 'hidden';
} else {
document.getElementById(ROOT_ELEMENT_ID)!.style.overflowY = 'auto';
}
}, [isPopoverOpen]);
}, [openPopovers]);

const columns: Array<EuiBasicTableColumn<typeof items[number]>> = [
{
Expand All @@ -84,7 +83,7 @@ export const TableView = (props: Props) => {
nodeType={nodeType}
closePopover={closePopoverFor(uniqueID)}
currentTime={currentTime}
isPopoverOpen={isPopoverOpen.includes(uniqueID)}
isPopoverOpen={openPopovers.includes(uniqueID)}
options={options}
popoverPosition="rightCenter"
>
Expand Down

0 comments on commit e4d45b5

Please sign in to comment.