Skip to content

Commit

Permalink
[APM] Renames significant terms feature to "Correlations" (#88974) (#…
Browse files Browse the repository at this point in the history
…89028)

* [APM] Renames significant terms feature to "Correlations" (#88974)

* fix capitalizations

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
  • Loading branch information
ogupte and kibanamachine committed Jan 25, 2021
1 parent f0f3820 commit edbd9ab
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 12 deletions.
2 changes: 1 addition & 1 deletion x-pack/plugins/apm/common/ui_settings_keys.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@
* you may not use this file except in compliance with the Elastic License.
*/

export const enableSignificantTerms = 'apm:enableSignificantTerms';
export const enableCorrelations = 'apm:enableCorrelations';
export const enableServiceOverview = 'apm:enableServiceOverview';
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ export function LatencyCorrelations() {
<EuiFormRow
fullWidth={true}
label="Field"
helpText="Fields to analyse for significant terms"
helpText="Fields to analyse for correlations"
>
<EuiComboBox
fullWidth={true}
Expand Down
10 changes: 5 additions & 5 deletions x-pack/plugins/apm/public/components/app/Correlations/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import {
import { useHistory } from 'react-router-dom';
import { EuiSpacer } from '@elastic/eui';
import { isActivePlatinumLicense } from '../../../../common/license_check';
import { enableSignificantTerms } from '../../../../common/ui_settings_keys';
import { enableCorrelations } from '../../../../common/ui_settings_keys';
import { useApmPluginContext } from '../../../context/apm_plugin/use_apm_plugin_context';
import { LatencyCorrelations } from './LatencyCorrelations';
import { ErrorCorrelations } from './ErrorCorrelations';
Expand All @@ -35,7 +35,7 @@ export function Correlations() {
const history = useHistory();
const [isFlyoutVisible, setIsFlyoutVisible] = useState(false);
if (
!uiSettings.get(enableSignificantTerms) ||
!uiSettings.get(enableCorrelations) ||
!isActivePlatinumLicense(license)
) {
return null;
Expand All @@ -48,7 +48,7 @@ export function Correlations() {
setIsFlyoutVisible(true);
}}
>
View significant terms
View correlations
</EuiButton>

<EuiSpacer size="s" />
Expand All @@ -62,7 +62,7 @@ export function Correlations() {
>
<EuiFlyoutHeader hasBorder aria-labelledby="correlations-flyout">
<EuiTitle>
<h2 id="correlations-flyout">Significant terms</h2>
<h2 id="correlations-flyout">Correlations</h2>
</EuiTitle>
</EuiFlyoutHeader>
<EuiFlyoutBody>
Expand All @@ -88,7 +88,7 @@ export function Correlations() {
iconType="alert"
>
<p>
Significant terms is an experimental feature and in active
Correlations is an experimental feature and in active
development. Bugs and surprises are to be expected but let us
know your feedback so we can improve it.
</p>
Expand Down
9 changes: 4 additions & 5 deletions x-pack/plugins/apm/server/ui_settings.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,25 +8,24 @@ import { schema } from '@kbn/config-schema';
import { i18n } from '@kbn/i18n';
import { UiSettingsParams } from '../../../../src/core/types';
import {
enableSignificantTerms,
enableCorrelations,
enableServiceOverview,
} from '../common/ui_settings_keys';

/**
* uiSettings definitions for APM.
*/
export const uiSettings: Record<string, UiSettingsParams<boolean>> = {
[enableSignificantTerms]: {
[enableCorrelations]: {
category: ['observability'],
name: i18n.translate('xpack.apm.enableCorrelationsExperimentName', {
defaultMessage: 'APM Significant terms (Platinum required)',
defaultMessage: 'APM correlations (Platinum required)',
}),
value: false,
description: i18n.translate(
'xpack.apm.enableCorrelationsExperimentDescription',
{
defaultMessage:
'Enable the experimental Significant terms feature in APM',
defaultMessage: 'Enable the experimental correlations feature in APM',
}
),
schema: schema.boolean(),
Expand Down

0 comments on commit edbd9ab

Please sign in to comment.