PR feedback pt3

elastic · Jun 17, 2019 · f11a6ae · f11a6ae
1 parent 39187c0
commit f11a6ae
Showing 1 changed file with 22 additions and 0 deletions.
diff --git a/x-pack/plugins/actions/server/__jest__/validate_action_type_config.test.ts b/x-pack/plugins/actions/server/__jest__/validate_action_type_config.test.ts
@@ -65,3 +65,25 @@ test('should validate and throw error when actionTypeConfig is invalid', () => {
     `"actionTypeConfig invalid: child \\"param1\\" fails because [\\"param1\\" is required]"`
   );
 });
+
+test('should not return values when actionTypeConfig is invalid', () => {
+  expect(() =>
+    validateActionTypeConfig(
+      {
+        id: 'my-action-type',
+        name: 'My action type',
+        validate: {
+          config: Joi.object()
+            .keys({
+              param1: Joi.number().required(),
+            })
+            .required(),
+        },
+        async executor() {},
+      },
+      { param1: 'my secret value' }
+    )
+  ).toThrowErrorMatchingInlineSnapshot(
+    `"actionTypeConfig invalid: child \\"param1\\" fails because [\\"param1\\" must be a number]"`
+  );
+});