Skip to content

Commit

Permalink
[Transforms] Avoid using "Are you sure" (#75932) (#76221)
Browse files Browse the repository at this point in the history
  • Loading branch information
lcawl authored Aug 31, 2020
1 parent 8cb32f4 commit f539f5b
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 44 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ import {
EuiSpacer,
EuiSwitch,
} from '@elastic/eui';
import { FormattedMessage } from '@kbn/i18n/react';
import { TRANSFORM_STATE } from '../../../../../../common';

import { DeleteAction } from './use_delete_action';

Expand All @@ -42,26 +40,11 @@ export const DeleteActionModal: FC<DeleteAction> = ({
}
);
const deleteModalTitle = i18n.translate('xpack.transform.transformList.deleteModalTitle', {
defaultMessage: 'Delete {transformId}',
defaultMessage: 'Delete {transformId}?',
values: { transformId: items[0] && items[0].config.id },
});
const bulkDeleteModalContent = (
<>
<p>
{shouldForceDelete ? (
<FormattedMessage
id="xpack.transform.transformList.bulkForceDeleteModalBody"
defaultMessage="Are you sure you want to force delete {count, plural, one {this} other {these}} {count} {count, plural, one {transform} other {transforms}}? The {count, plural, one {transform} other {transforms}} will be deleted regardless of {count, plural, one {its} other {their}} current state."
values={{ count: items.length }}
/>
) : (
<FormattedMessage
id="xpack.transform.transformList.bulkDeleteModalBody"
defaultMessage="Are you sure you want to delete {count, plural, one {this} other {these}} {count} {count, plural, one {transform} other {transforms}}?"
values={{ count: items.length }}
/>
)}
</p>
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
{
Expand Down Expand Up @@ -100,19 +83,6 @@ export const DeleteActionModal: FC<DeleteAction> = ({

const deleteModalContent = (
<>
<p>
{items[0] && items[0] && items[0].stats.state === TRANSFORM_STATE.FAILED ? (
<FormattedMessage
id="xpack.transform.transformList.forceDeleteModalBody"
defaultMessage="Are you sure you want to force delete this transform? The transform will be deleted regardless of its current state."
/>
) : (
<FormattedMessage
id="xpack.transform.transformList.deleteModalBody"
defaultMessage="Are you sure you want to delete this transform?"
/>
)}
</p>
<EuiFlexGroup direction="column" gutterSize="none">
<EuiFlexItem>
{userCanDeleteIndex && (
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, items, startAndC
values: { count: items && items.length },
});
const startModalTitle = i18n.translate('xpack.transform.transformList.startModalTitle', {
defaultMessage: 'Start {transformId}',
defaultMessage: 'Start {transformId}?',
values: { transformId: items[0] && items[0].config.id },
});

Expand All @@ -40,8 +40,7 @@ export const StartActionModal: FC<StartAction> = ({ closeModal, items, startAndC
<p>
{i18n.translate('xpack.transform.transformList.startModalBody', {
defaultMessage:
'A transform will increase search and indexing load in your cluster. Please stop the transform if excessive load is experienced. Are you sure you want to start {count, plural, one {this} other {these}} {count} {count, plural, one {transform} other {transforms}}?',
values: { count: items.length },
'A transform increases search and indexing load in your cluster. If excessive load is experienced, stop the transform.',
})}
</p>
</EuiConfirmModal>
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/translations/translations/ja-JP.json
Original file line number Diff line number Diff line change
Expand Up @@ -18172,17 +18172,14 @@
"xpack.transform.transformForm.sizeNotationPlaceholder": "例: {example1}、{example2}、{example3}、{example4}",
"xpack.transform.transformList.bulkDeleteDestIndexPatternSuccessMessage": "{count}個のディスティネーションインデックス{count, plural, one {パターン} other {パターン}}を正常に削除しました。",
"xpack.transform.transformList.bulkDeleteDestIndexSuccessMessage": "{count}個のディスティネーション{count, plural, one {インデックス} other {インデックス}}を正常に削除しました。",
"xpack.transform.transformList.bulkDeleteModalBody": "{count, plural, one {この} other {これらの}} {count} {count, plural, one {変換} other {変換}}を削除しますか?",
"xpack.transform.transformList.bulkDeleteModalTitle": "{count} 件の{count, plural, one {変換} other {変換}}を削除",
"xpack.transform.transformList.bulkDeleteTransformSuccessMessage": "{count} {count, plural, one {個の変換} other {個の変換}}を正常に削除しました。",
"xpack.transform.transformList.bulkForceDeleteModalBody": "{count, plural, one {この} other {これらの}} {count} {count, plural, one {変換} other {変換}}を強制的に削除しますか?{count, plural, one {} other {}}現在の状態に関係なく、{count, plural, one {個の変換} other {個の変換}}は削除されます。",
"xpack.transform.transformList.bulkStartModalTitle": "{count} 件の{count, plural, one {変換} other {変換}}を開始",
"xpack.transform.transformList.completeBatchTransformBulkActionToolTip": "1 つまたは複数の変換が完了済みの一斉変換で、再度開始できません。",
"xpack.transform.transformList.completeBatchTransformToolTip": "{transformId} は完了済みの一斉変換で、再度開始できません。",
"xpack.transform.transformList.createTransformButton": "変換の作成",
"xpack.transform.transformList.deleteActionDisabledToolTipContent": "削除するにはデータフレームジョブを停止してください。",
"xpack.transform.transformList.deleteBulkActionDisabledToolTipContent": "削除するには、選択された変換のうちの 1 つまたは複数を停止する必要があります。",
"xpack.transform.transformList.deleteModalBody": "この変換を削除してよろしいですか?",
"xpack.transform.transformList.deleteModalCancelButton": "キャンセル",
"xpack.transform.transformList.deleteModalDeleteButton": "削除",
"xpack.transform.transformList.deleteModalTitle": "{transformId} 削除",
Expand All @@ -18205,14 +18202,12 @@
"xpack.transform.transformList.editTransformGenericErrorMessage": "変換を削除するためのAPIエンドポイントの呼び出し中にエラーが発生しました。",
"xpack.transform.transformList.editTransformSuccessMessage": "変換{transformId}が更新されました。",
"xpack.transform.transformList.errorWithCheckingIfUserCanDeleteIndexNotificationErrorMessage": "ユーザーがディスティネーションインデックスを削除できるかどうかを確認するときにエラーが発生しました。",
"xpack.transform.transformList.forceDeleteModalBody": "この変換を強制的に削除しますか?現在の状態に関係なく、変換が削除されます。",
"xpack.transform.transformList.refreshButtonLabel": "更新",
"xpack.transform.transformList.rowCollapse": "{transformId} の詳細を非表示",
"xpack.transform.transformList.rowExpand": "{transformId} の詳細を表示",
"xpack.transform.transformList.showDetailsColumn.screenReaderDescription": "このカラムには変換ごとの詳細を示すクリック可能なコントロールが含まれます",
"xpack.transform.transformList.startedTransformBulkToolTip": "1 つまたは複数の変換が既に開始済みです。",
"xpack.transform.transformList.startedTransformToolTip": "{transformId} は既に開始済みです。",
"xpack.transform.transformList.startModalBody": "変換は、クラスターの検索とインデックスによる負荷を増やします。過剰な負荷が生じた場合は変換を停止してください。{count, plural, one {この} other {これら}} {count} 件の{count, plural, one {変換} other {変換}}を開始してよろしいですか?",
"xpack.transform.transformList.startModalCancelButton": "キャンセル",
"xpack.transform.transformList.startModalStartButton": "開始",
"xpack.transform.transformList.startModalTitle": "{transformId} を開始",
Expand Down
5 changes: 0 additions & 5 deletions x-pack/plugins/translations/translations/zh-CN.json
Original file line number Diff line number Diff line change
Expand Up @@ -18178,17 +18178,14 @@
"xpack.transform.transformForm.sizeNotationPlaceholder": "示例:{example1}、{example2}、{example3}、{example4}",
"xpack.transform.transformList.bulkDeleteDestIndexPatternSuccessMessage": "已成功删除 {count} 个目标索引{count, plural, one {模式} other {模式}}。",
"xpack.transform.transformList.bulkDeleteDestIndexSuccessMessage": "已成功删除 {count} 个目标{count, plural, one {索引} other {索引}}。",
"xpack.transform.transformList.bulkDeleteModalBody": "确定要删除{count, plural, one {这} other {这}} {count} 个{count, plural, one {转换} other {转换}}?",
"xpack.transform.transformList.bulkDeleteModalTitle": "删除 {count} 个 {count, plural, one {转换} other {转换}}?",
"xpack.transform.transformList.bulkDeleteTransformSuccessMessage": "已成功删除 {count} 个{count, plural, one {转换} other {转换}}。",
"xpack.transform.transformList.bulkForceDeleteModalBody": "确定要强制删除{count, plural, one {这} other {这}} {count} 个{count, plural, one {转换} other {转换}}?无论{count, plural, one {转换} other {转换}}的当前状态如何,都将删除{count, plural, one {} other {}}。",
"xpack.transform.transformList.bulkStartModalTitle": "启动 {count} 个 {count, plural, one {转换} other {转换}}?",
"xpack.transform.transformList.completeBatchTransformBulkActionToolTip": "一个或多个转换为已完成批量转换,无法重新启动。",
"xpack.transform.transformList.completeBatchTransformToolTip": "{transformId} 为已完成批量转换,无法重新启动。",
"xpack.transform.transformList.createTransformButton": "创建转换",
"xpack.transform.transformList.deleteActionDisabledToolTipContent": "停止数据帧作业,以便将其删除。",
"xpack.transform.transformList.deleteBulkActionDisabledToolTipContent": "一个或多个选定数据帧转换必须停止,才能删除。",
"xpack.transform.transformList.deleteModalBody": "是否确定要删除此转换?",
"xpack.transform.transformList.deleteModalCancelButton": "取消",
"xpack.transform.transformList.deleteModalDeleteButton": "删除",
"xpack.transform.transformList.deleteModalTitle": "删除 {transformId}",
Expand All @@ -18211,14 +18208,12 @@
"xpack.transform.transformList.editTransformGenericErrorMessage": "调用用于更新转换的 API 终端时发生错误。",
"xpack.transform.transformList.editTransformSuccessMessage": "转换 {transformId} 已更新。",
"xpack.transform.transformList.errorWithCheckingIfUserCanDeleteIndexNotificationErrorMessage": "检查用户是否可以删除目标索引时发生错误",
"xpack.transform.transformList.forceDeleteModalBody": "确定要强制删除此索引?无论转换的当前状态如何,都将删除。",
"xpack.transform.transformList.refreshButtonLabel": "刷新",
"xpack.transform.transformList.rowCollapse": "隐藏 {transformId} 的详情",
"xpack.transform.transformList.rowExpand": "显示 {transformId} 的详情",
"xpack.transform.transformList.showDetailsColumn.screenReaderDescription": "此列包含可单击控件,用于显示每个转换的更多详情",
"xpack.transform.transformList.startedTransformBulkToolTip": "一个或多个选定数据帧转换已启动。",
"xpack.transform.transformList.startedTransformToolTip": "{transformId} 已启动。",
"xpack.transform.transformList.startModalBody": "转换将增加集群的搜索和索引负荷。如果负荷超载,请停止转换。是否确定要启动{count, plural, one {这} other {这}} {count} 个 {count, plural, one {转换} other {转换}}?",
"xpack.transform.transformList.startModalCancelButton": "取消",
"xpack.transform.transformList.startModalStartButton": "启动",
"xpack.transform.transformList.startModalTitle": "启动 {transformId}",
Expand Down

0 comments on commit f539f5b

Please sign in to comment.