Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Create generic "embeddable" function #101633

Closed
3 tasks done
crob611 opened this issue Jun 8, 2021 · 1 comment · Fixed by #113827
Closed
3 tasks done

[Canvas] Create generic "embeddable" function #101633

crob611 opened this issue Jun 8, 2021 · 1 comment · Fixed by #113827
Assignees
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@crob611
Copy link
Contributor

crob611 commented Jun 8, 2021

There should be an "embeddable" function that takes in an input argument that is just a big config object. This will allow for by reference or by value embeddables.

  • The underlying config should be "hidden" from the user when viewing the expression. Because it will just be a big json blob, the user will not be directly editing this, but we'll still need to show the expression.
  • Config will need to be in the expression, not on the element probably, as the config will need to be accessible elsewhere for migration, etc?
  • Input should still be updated as it changes through interaction (recentering a map, etc)

Resulting expression will be something like embeddable input={{key: value, key2: value2}}

@crob611 crob611 added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jun 8, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants