Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Canvas] Persist embeddable input #107896

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Aug 9, 2021

Related to #81812.
Related to #101633.
Blocked by #104499.

This adds an input property to the workpad element schema, and stores the embeddable input as a base64 encoded string. It operates the same way filters currently do in Canvas.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@cqliu1 cqliu1 added Feature:Canvas Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WIP Work in progress impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes labels Aug 9, 2021
    Fixed telemetry

    Updates expression on input change

    Fixed ts errors
@cqliu1 cqliu1 force-pushed the canvas/store-embeddable-input branch from 67e82f3 to 560dd6b Compare August 11, 2021 17:09
Fixed ts errors

Fixed disappearing embeddable
@cqliu1 cqliu1 force-pushed the canvas/store-embeddable-input branch from 560dd6b to 2406e77 Compare August 11, 2021 17:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cqliu1 cqliu1 closed this Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Canvas impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas WIP Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants