Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring][Angular removal] Migrate kibana views #111767

Closed
3 tasks done
Tracked by #111309
estermv opened this issue Sep 9, 2021 · 8 comments · Fixed by #113962
Closed
3 tasks done
Tracked by #111309

[Stack Monitoring][Angular removal] Migrate kibana views #111767

estermv opened this issue Sep 9, 2021 · 8 comments · Fixed by #113962
Assignees
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@estermv
Copy link
Contributor

estermv commented Sep 9, 2021

Migrate views under views/kibana

@estermv estermv added Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Epic: Stack Monitoring de-angularization labels Sep 9, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@klacabane
Copy link
Contributor

klacabane commented Sep 29, 2021

I'll get started with the Overview page following the steps defined here.

@klacabane
Copy link
Contributor

klacabane commented Sep 29, 2021

While testing the graphs in the overview page it looks like we have a regression on the zoom-out action which seems to be a no-op atm. Steps to reproduce:

  • Pick a period on a graph to trigger the zoom-in action. Action behaves properly with the timepicker being updated to be in-sync with the url query.
  • Click 'Zoom out' on a graph. Url query is updated to reflect to n-1 timeframe but the timepicker doesn't change, graph is not updated as well. After ~10sec the graph is updated to be in-sync with the active timeframe, probably a background interval that causes a repaint ?

Same behavior on firefox and chrome

@jasonrhodes
Copy link
Member

@klacabane do you mean there is a regression in the existing code or only in the migrated code? And on which page do you see this?

@klacabane
Copy link
Contributor

Happens in the migrated code, behavior is as expected in the Angular code. Happens on both Elasticsearch overview and Kibana overview, but I suppose any migrated page that use the similar components is impacted.

Issue is already tracked in #112063 so I'll move on :)

@matschaffer
Copy link
Contributor

@klacabane good you found that one :) yeah right now any zoom/brush/zoomout can trigger this. I think it's okay to move on and we can address it later. Maybe even after angular removal.

@klacabane
Copy link
Contributor

Will do the Instances page next. Planning to use the docker setup to have n kibana instances in order to enable and test pagination.

@klacabane
Copy link
Contributor

Instances page merged, following up with #113873 before moving to the Instance page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants