Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] SetupMode pane renders stale data #113873

Closed
Tracked by #115026
klacabane opened this issue Oct 4, 2021 · 2 comments
Closed
Tracked by #115026

[Stack Monitoring] SetupMode pane renders stale data #113873

klacabane opened this issue Oct 4, 2021 · 2 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@klacabane
Copy link
Contributor

When entering the setup mode in kibana instances page, the app should poll a setup-related api /api/monitoring/v1/setup/collection/cluster/:id every n seconds to update instances migration state, as well as notifying the user that data was detected and migration is done if the pane is open.

In the react code we only call that api once when entering the setup mode and then continuously renders stale data. The issue may appear in any pages that use the setup mode.


Relevant code that is maybe not called on re-renders ?

@klacabane klacabane added bug Fixes for quality problems that affect the customer experience Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Feature:Stack Monitoring Epic: Stack Monitoring de-angularization labels Oct 4, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@matschaffer matschaffer changed the title SetupMode pane renders stale data [Stack Monitoring] SetupMode pane renders stale data Oct 5, 2021
@estermv
Copy link
Contributor

estermv commented Oct 5, 2021

We need to call the method that you mention inside the refresh callback when the setup mode is enabled as it was done in Angular here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Epic: Stack Monitoring de-angularization Feature:Stack Monitoring Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

3 participants