Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stack Monitoring] update setup mode data when required #113934

Merged
merged 1 commit into from
Oct 6, 2021
Merged

[Stack Monitoring] update setup mode data when required #113934

merged 1 commit into from
Oct 6, 2021

Conversation

klacabane
Copy link
Contributor

Summary

Context here #113873

Testing

  • verified api/monitoring/v1/setup/collection/cluster/:id was polled in setup mode
  • created a legacy-monitored kibana instance, opened the setup mode panel and followed instructions. Ensured metricbeat data was detected and the ui was updated accordingly

Screenshot 2021-10-05 at 15 23 09

@klacabane klacabane added Team:Monitoring Stack Monitoring team v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes Feature:Stack Monitoring auto-backport Deprecated - use backport:version if exact versions are needed v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 5, 2021
@klacabane klacabane requested a review from a team as a code owner October 5, 2021 13:35
@klacabane klacabane requested review from a team October 5, 2021 13:35
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1011.0KB 1011.2KB +144.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

estermv
estermv approved these changes Oct 6, 2021
View reviewed changes
Copy link
Contributor

@estermv estermv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👏

I've tried also to enable Metricbeat monitoring from the Elasticsearch nodes pages (it should work similar as it works for kibana instances) but there is an error when entering the setup mode there. I logged a separate ticket to look into this -> #114076

x-pack/plugins/monitoring/public/application/pages/page_template.tsx
requests.push(updateSetupModeData());
}

Promise.allSettled(requests).then((results) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be .catch because if I'm not missing anything here we don't have to do anything with results, we only want to process errors. (Although I'm working on the errors page, so I can also change it after you merge it to master)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

allSettled never rejects. Thought it would be appropriate here since requests don't look related and individual error handling may be a good option, but I'll leave it for the tasks dedicated to that :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't notice the allSettled 🙃, I'll work on it in my PR

@klacabane klacabane merged commit bc843c9 into elastic:master Oct 6, 2021
@klacabane klacabane deleted the refresh-setup-mode branch October 6, 2021 11:30
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 6, 2021
@klacabane @kibanamachine
update setup mode data when required (elastic#113934)
c5d98ff
@kibanamachine kibanamachine mentioned this pull request Oct 6, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Oct 6, 2021
@kibanamachine @klacabane
update setup mode data when required (#113934) (#114085)
eec9482 
Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
@estermv estermv mentioned this pull request Oct 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estermv estermv estermv approved these changes

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Epic: Stack Monitoring de-angularization Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Monitoring Stack Monitoring team v7.16.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@klacabane @elasticmachine @kibanamachine @estermv