[Search] Remove search:includeFrozen setting

[lukasolson]

See elastic/elasticsearch#77864.

The ignore_throttled parameter has been deprecated by Elasticsearch (as well as frozen indices itself). As a result, we need to deprecate (and eventually remove) the search:includeFrozen advanced setting (which corresponds with whether or not we send this parameter in search requests). As of now, enabling this advanced setting results in warning toast notifications (which make some functional tests fail):

Open questions:

• When is this parameter being removed entirely from Elasticsearch? Answer: v9.0
• Should we replace this advanced setting with something that allows you which tiers you want to search (e.g. data_hot, data_warm, etc.)? TBD - Not initially

[elasticmachine]

Pinging @elastic/kibana-app-services (Team:AppServices)

[pheyos]

I'd like to add to the description that in my local tests I can see the deprecation warning toasts coming up, even if I have the search:includeFrozen advanced setting disabled (which is the default). I thought I could maybe add a quick fix for the tests by changing this advanced setting, but it doesn't make a difference there.

[cjcenizal]

Per #112627, I do think we need to disable this setting by default in 7.16, or else the deprecation logging UX in Upgrade Assistant is degraded.

[lukasolson]

I'd like to add to the description that in my local tests I can see the deprecation warning toasts coming up, even if I have the search:includeFrozen advanced setting disabled (which is the default). I thought I could maybe add a quick fix for the tests by changing this advanced setting, but it doesn't make a difference there.

Hmm, I think this is probably because we always send this parameter (instead of only sending it when search:includeFrozen is set to true). This should at least be a quick fix to only send it when it's true.

[tylersmalley]

For now, I believe we silence this error since it's because of our usage of it and not something actionable by the user.

Currently, this modal is preventing the promotion of the ES snapshot which is currently an issue for the ML team.

[tylersmalley]

And to be clear, this deprecation was added to 7.16.

[cjcenizal]

I just tested on Cloud and I can confirm that this is now fixed, based on what I reported in my duplicate issue #112627.

[bhavyarm]

@lukasolson I upgraded ES to 7.16.0 BC3 from 7.15.2 BC1 and ran it with Kibana 7.15.2 BC1 and see this all over. Do we plan to fix this in 7.16? Thanks!

[lukasolson]

@bhavyarm We actually plan on removing the warning notifications from search requests altogether: #117252

[madhutomy]

@lukasolson Which version has the fix to remove the warning pop ups?

[lukasolson]

Which version has the fix to remove the warning pop ups?

I believe the PR landed in 7.16.0.

[madhutomy]

excellent thanks

[TinaHeiligers]

We might need to handle this more urgently than for the next major, since there have already been 2 cases I'm aware of that case "Parse Error: Header overflow" when searching an index that matches an alias that includes frozen indices.

I think we should deprecate these as soon as possible.

[elasticmachine]

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)