Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usages of search:includeFrozen advanced setting #192650

Open
lukasolson opened this issue Sep 11, 2024 · 1 comment
Open

Remove usages of search:includeFrozen advanced setting #192650

lukasolson opened this issue Sep 11, 2024 · 1 comment
Labels
Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v9.0.0

Comments

@lukasolson
Copy link
Member

Part of #112621.

In 9.0, Elasticsearch will no longer support unfreezing indices. Any existing frozen indices will be unfrozen automatically. (See elastic/elasticsearch#70192.)

As a result, we should no longer be sending the ignore_throttled parameter in search requests.

Currently there's an advanced setting, search:includeFrozen, which is deprecated and slated to be removed in 9.0.

We need to remove all references to this advanced setting & ensure we're no longer sending the ignore_throttled parameter in search requests.

Following are a number of existing references:

Observability solution

const includeFrozen = await uiSettings.client.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

const includeFrozen = await uiSettings.client.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

const includeFrozen = await uiSettings.client.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

coreContext.uiSettings.client.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN)

uiSettingsClient.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN),

Reporting (export CSV)

client.get(UI_SETTINGS_SEARCH_INCLUDE_FROZEN),

Unified field list

const includeFrozen = uiSettingsClient.get(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

Data

const includeFrozen = await uiSettingsClient.get(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

Timelion

const includeFrozen = Boolean(tlConfig.settings[UI_SETTINGS.SEARCH_INCLUDE_FROZEN]);

Graph

const includeFrozen = await uiSettings.get<boolean>(UI_SETTINGS.SEARCH_INCLUDE_FROZEN);

@lukasolson lukasolson added Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v9.0.0 labels Sep 11, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) v9.0.0
Projects
None yet
Development

No branches or pull requests

2 participants