Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Fix enable_monitoring functional test #114866

Closed
Tracked by #114160
klacabane opened this issue Oct 13, 2021 · 6 comments
Closed
Tracked by #114160

[Stack Monitoring] Fix enable_monitoring functional test #114866

klacabane opened this issue Oct 13, 2021 · 6 comments
Assignees
Labels
Epic: Stack Monitoring de-angularization Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@klacabane
Copy link
Contributor

klacabane commented Oct 13, 2021

Only one test there. Failing for a missing test-subj attribute noDataContainer.

cmd:
node scripts/functional_test_runner --config x-pack/test/functional/config.js --grep "Monitoring app Monitoring" --quiet

...
       └-> "after all" hook for "Monitoring enabled"
       └-> "after all" hook for "Monitoring enabled"
     └-> "after all" hook in "Monitoring app"
 
 0 passing (2.0m)
 1 failing
 
 1)    Monitoring app
        Monitoring is turned off
          "before all" hook for "Monitoring enabled":
 
       Error: retry.try timeout: TimeoutError: Waiting for element to be located By(css selector, [data-test-subj="noDataContainer"])
  Wait timed out after 10053ms
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 13, 2021
@klacabane klacabane added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Oct 13, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 13, 2021
@klacabane klacabane self-assigned this Oct 14, 2021
@klacabane
Copy link
Contributor Author

klacabane commented Oct 14, 2021

Added the noDataContainer subj and now got a failure trying to target the Refresh button which has a querySubmitButton test-subj. Looks like we're using a dependency (EUI) component for that, I'd expect both versions to use it but somehow the test-subj is not appearing in the react version, so I guess they are two different ones ? I'll look into that.

Now why are we clicking this refresh button on a NoData page ? Looking at git history it appears that it was initially to Handle cloud test failures, but I can't find an explanation as to why it fixed the issue. Moving up the history we see that these tests were disabled for cloud sometime later. So for now It seems safe to remove this step to cleanup unnecessary code, remove a dependency on 3p component and also to unblock me :).

@klacabane
Copy link
Contributor Author

Tests are passing on angular version after removing the "click refresh button" step but they're still failing for react on the following step when trying to locate the clusterOverviewContainer > clusterName element

@estermv
Copy link
Contributor

estermv commented Oct 14, 2021

Tests are passing on angular version after removing the "click refresh button" step but they're still failing for react on the following step when trying to locate the clusterOverviewContainer > clusterName element

@klacabane I fixed this error on my PR: #114982

@klacabane
Copy link
Contributor Author

Confirming test pass smoothly with @estermv change. I'll submit PR

@matschaffer
Copy link
Contributor

PR is merged and we passed CI, so calling this done. @klacabane if there's more work to do please add it to #115026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants