Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stack Monitoring] Fix monitoring func test #115013

Merged
merged 6 commits into from
Oct 14, 2021

Conversation

klacabane
Copy link
Contributor

Summary

Context #114866

Testing

  • enable render_react_app
  • start test server node scripts/functional_tests_server --config x-pack/test/functional/config.js
  • run tests node scripts/functional_test_runner --config x-pack/test/functional/config.js --grep "Monitoring app Monitoring"
  • verified test is passing in both angular and react versions
...
       └- ✓ pass  (22.3s) "Monitoring app Monitoring is turned off Monitoring enabled"
     └-> "after all" hook for "Monitoring enabled"
       │ debg No indices to delete [pattern=/.monitoring-*]
     └-> "after all" hook for "Monitoring enabled"
   └-> "after all" hook in "Monitoring app"

1 passing (30.0s)

@klacabane klacabane added Team:Monitoring Stack Monitoring team v8.0.0 Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services release_note:skip Skip the PR/issue when compiling release notes v7.16.0 Epic: Stack Monitoring de-angularization labels Oct 14, 2021
@klacabane klacabane requested a review from a team as a code owner October 14, 2021 14:03
@klacabane klacabane requested review from a team October 14, 2021 14:03
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@klacabane
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1.1MB 1.1MB +103.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@klacabane klacabane merged commit e49ec25 into elastic:master Oct 14, 2021
@klacabane klacabane deleted the fix-monitoring-func-test branch October 14, 2021 20:48
matschaffer pushed a commit to matschaffer/kibana that referenced this pull request Oct 15, 2021
* add noDataContainer test-subj

* remove unnecessary test step

* Fix test subjects for overview page

* remove unused service

* update NoData component snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
matschaffer added a commit that referenced this pull request Oct 15, 2021
* [Stack Monitoring] Fix monitoring func test (#115013)

* add noDataContainer test-subj

* remove unnecessary test step

* Fix test subjects for overview page

* remove unused service

* update NoData component snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* Update snaps to include items not backported from #52276

Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
artem-shelkovnikov pushed a commit to artem-shelkovnikov/kibana that referenced this pull request Oct 20, 2021
* add noDataContainer test-subj

* remove unnecessary test step

* Fix test subjects for overview page

* remove unused service

* update NoData component snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Stack Monitoring de-angularization release_note:skip Skip the PR/issue when compiling release notes Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services Team:Monitoring Stack Monitoring team v7.16.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants