Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Stack Monitoring] Fix monitoring func test (#115013) #115140

Merged
merged 2 commits into from
Oct 15, 2021

Conversation

matschaffer
Copy link
Contributor

Backports the following commits to 7.x:

* add noDataContainer test-subj

* remove unnecessary test step

* Fix test subjects for overview page

* remove unused service

* update NoData component snapshots

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@matschaffer matschaffer enabled auto-merge (squash) October 15, 2021 05:20
@matschaffer
Copy link
Contributor Author

Hm, looks like #52276 never got back ported to 7.x (cc @cachedout ) so this change has a bit more than the 8.0 change.

Not sure if the lack of backport is intentional or maybe I'm just missing it. Pretty old PR so could be the process was a little different?

Guess we'll see if these pass tests and go from there.

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
monitoring 1.1MB 1.1MB +837.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @matschaffer

@matschaffer matschaffer merged commit b87894f into elastic:7.x Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants