Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/uptime/synthetics_integration·ts - Uptime app with generated data When on the Synthetics Integration Policy Create Page displays custom UI "before all" hook for "should display policy view" #116522

Closed
kibanamachine opened this issue Oct 27, 2021 · 26 comments
Assignees
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 27, 2021

A test failed on a tracked branch

Error: retry.try timeout: Error: Synthetics package was not in response from /api/fleet/epm/packages
    at /opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/x-pack/test/functional/services/uptime/synthetics_package.ts:64:23
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at runAttempt (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry_for_success.ts:29:15)
    at retryForSuccess (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry_for_success.ts:68:21)
    at RetryService.try (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry.ts:31:12)
    at Object.getSyntheticsPackageVersion (test/functional/services/uptime/synthetics_package.ts:84:33)
    at Context.<anonymous> (test/functional/apps/uptime/synthetics_integration.ts:157:25)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)
    at onFailure (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry_for_success.ts:17:9)
    at retryForSuccess (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry_for_success.ts:59:13)
    at RetryService.try (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/test/common/services/retry/retry.ts:31:12)
    at Object.getSyntheticsPackageVersion (test/functional/services/uptime/synthetics_package.ts:84:33)
    at Context.<anonymous> (test/functional/apps/uptime/synthetics_integration.ts:157:25)
    at Object.apply (/opt/local-ssd/buildkite/builds/kb-cigroup-6-4026b0466283d460/elastic/kibana-hourly/kibana/node_modules/@kbn/test/target_node/functional_test_runner/lib/mocha/wrap_function.js:87:16)

First failure: CI Build - 8.0

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Oct 27, 2021
@botelastic botelastic bot added the needs-team Issues missing a team label label Oct 27, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@mistic mistic added the Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability label Oct 28, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Oct 28, 2021
@joshdover
Copy link
Contributor

The test is here:

// Currently (as of 2020-june) the package registry used in CI is the public one and
// at times it encounters network connection issues. We use `retry.try` below to see if
// subsequent requests get through.
apiRequest = retry.try(() => {
return supertest
.get(INGEST_API_EPM_PACKAGES)
.set('kbn-xsrf', 'xxx')
.expect(200)
.catch((error) => {
return logSupertestApiErrorAndThrow(`Unable to retrieve packages via Ingest!`, error);
})
.then((response: { body: GetPackagesResponse }) => {
const { body } = response;
const syntheticsPackageInfo = body.response.find(
(epmPackage) => epmPackage.name === 'synthetics'
);
if (!syntheticsPackageInfo) {
throw new Error(
`Synthetics package was not in response from ${INGEST_API_EPM_PACKAGES}`
);
}

I think the comment at the top indicates the issue. Instead of using the production EPR, we should set these tests up to use a local docker image of EPR just like we do for Fleet's API integration tests.

This can be done by:

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

jbudz added a commit that referenced this issue Oct 28, 2021
@jbudz
Copy link
Member

jbudz commented Oct 28, 2021

skipped

8.0: 9e2bda7

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 8.0

@lucasfcosta
Copy link
Contributor

@dominiqueclarke this issue seems to be in the Needs Review column, and I couldn't see the changes pointed by @joshdover in the other PR. However, you mentioned your PR solves this issue.

Can you confirm or let me know if I need to do further changes to address this flaky test?

@dominiqueclarke
Copy link
Contributor

@paulb-elastic The tests are now unskipped, but this ticket relates to an enhancement to our current tests. Moving to 8.0.0.

@lucasfcosta
Copy link
Contributor

As we previously discussed, addressing these flaky tests depend on having a local EPR.

This issue seems to have been somewhat superseded by the initiative described in #116591, so I added a comment to double check whether the Kibana Operations/Fleet teams expect us to implement the local EPR ourselves or whether they'll do it across the board for consistency/technical/other reasons.

@dominiqueclarke
Copy link
Contributor

Closed by #117736

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

@kibanamachine kibanamachine reopened this Feb 16, 2022
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

@dominiqueclarke
Copy link
Contributor

@paulb-elastic This should be resolved by #125127. Let's see if another failure pops up. Don't think it's worth investigating at this time.

@dominiqueclarke
Copy link
Contributor

I think I spoke too soon on this one. I initially thought the new failures were from 8.2.0, but now that I see they are in 7.15, we should investigate. This is likely do to this change in package registry: elastic/package-registry@4a270e4

@joshdover
Copy link
Contributor

@dominiqueclarke Since we're no longer maintaining the 7.15 branch I think we can just close this now.

@dominiqueclarke
Copy link
Contributor

Closing due to 7.15 no longer being maintained.

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.15

@jbudz jbudz closed this as completed Mar 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
failed-test A test failure on a tracked branch, potentially flaky-test Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability
Projects
None yet
Development

No branches or pull requests

7 participants