[Uptime] Users can't save ML Job alerts and see error when they don't have write access to uptime #118404

lucasfcosta · 2021-11-11T18:02:46Z

Kibana version: 8.1.0 (Source - Hash: a51a04b)

Elasticsearch version: 8.1.0 (Remote cluster configured for CCS)

Server OS version: MacOS 11.6 Big Sur

Browser version: Version 95.0.4638.69 (Official Build) (x86_64)

Browser OS version: MacOS 11.6 Big Sur

Original install method (e.g. download page, yum, from source, etc.): Running Kibana from source, and connecting it to a remote cluster configured for CCS against oblt-dev (which was created using oblt-cli).

Describe the bug: When users don't have permissions to write to uptime, but can see the Monitors screen and create ML Jobs, they see an error when trying to create an alert on top of the monitor duration's anomaly detection.

That's confusing behaviour because the button to create the alert remains enabled on the screen despite the user not having permission to actually do so.

Steps to reproduce:

Create a new role which has All privileges for Machine Learning and read-only access to Uptime, as per the screenshot below.
Create a user and assign it the role you created in step 1 and the obs_read role, as per the screenshot below.
Create and start a synthetic monitor. This can be a simple monitor, like one with an HTTP check, for example.
Login with the user you just created and access the synthetic monitor you just created.
Within the monitor's details, click Enable anomaly detection and create an ML Job for it.
Try to save an alert (you don't need to add any connectors) and you'll see an error.

Expected behavior: The button to create alerts should be disabled so that users can't even open the flyout, as it currently happens on the Logs app (shown in the screenshot below).

Screenshots (if relevant):

Errors in browser console (if relevant):

POST http://localhost:5601/ktg/api/alerting/rule 403 (Forbidden)

Provide logs and/or server output (if relevant): None.

Any additional context: This was broken out from the PR #117684 to prevent its scope from increasing indefinitely.

The text was updated successfully, but these errors were encountered:

elasticmachine · 2021-11-11T18:02:48Z

Pinging @elastic/uptime (Team:uptime)

lucasfcosta · 2021-12-01T09:42:58Z

As an update to the expected behaviour, we have decided that:

The button to create alerts should be disabled so that users can't even open the flyout, as it currently happens on the Logs app (shown in the screenshot below).

We decided to do this because:

It's a pattern already used elsewhere
It doesn't require changing other team's components
We'll eventually move away from the current alerting setup component

I've also updated this issue to reflect that.

…rite permissions [elastic#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip.

…ime [elastic#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app.

…rite permissions [elastic#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip.

…ime [elastic#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app.

…rite permissions [elastic#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip.

…ime [elastic#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app.

…rite permissions [#118404] (#120379) * [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip. * [Uptime] Disable "Enable Anomaly Alert" when users can't write to uptime [#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…rite permissions [elastic#118404] (elastic#120379) * [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [elastic#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip. * [Uptime] Disable "Enable Anomaly Alert" when users can't write to uptime [elastic#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

…time write permissions [#118404] (#120379) (#121163) * [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [#118404] (#120379) * [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip. * [Uptime] Disable "Enable Anomaly Alert" when users can't write to uptime [#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * add missing useKibana hook to ML Flyout Container for detecting uptime write permissions Co-authored-by: Lucas F. da Costa <lucas@lucasfcosta.com> Co-authored-by: Lucas Fernandes da Costa <lucas.costa@elastic.co>

dominiqueclarke · 2021-12-16T22:40:38Z

Post FF testing LGTM. Tested with 8.0 branch.

Created a Kibana user with only read access to All Kibana privileges and read access to the heartbeat-* and synthetics-* indices.

…rite permissions [elastic#118404] (elastic#120379) * [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [elastic#118404] Before this commit, users would be able to open the flyout to create an alert and would end-up seeing an error toast when they tried to save it. This commit will now disable the create alert button when the user doesn't have permissions to write to Uptime. It will also display a helpful tooltip. * [Uptime] Disable "Enable Anomaly Alert" when users can't write to uptime [elastic#118404] This commit causes users not to be able to use the "Enable Anomaly Alert" button within the popover in the monitors screen. That button will now be disabled and contain an informative tooltip whenever users don't have permissions to write to Uptime. We've chosen to take this approach so that we don't have to modify the component which deals with the alert creation, which belongs to another team and that we plan on eventually replacing. Furthermore, this pattern is already used in the logs app. Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

lucasfcosta added bug Fixes for quality problems that affect the customer experience v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v8.1.0 labels Nov 11, 2021

lucasfcosta mentioned this issue Nov 11, 2021

[Uptime] Add callout to ML jobs flyout when users don't have the necessary permissions #117684

Merged

9 tasks

paulb-elastic assigned lucasfcosta Nov 15, 2021

lucasfcosta mentioned this issue Dec 3, 2021

[Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [#118404] #120379

Merged

9 tasks

lucasfcosta closed this as completed in #120379 Dec 14, 2021

kibanamachine mentioned this issue Dec 14, 2021

[8.0] [Uptime] Disable 'Create Rule' button when user doesn't have uptime write permissions [#118404] (#120379) #121163

Merged

lucasfcosta removed their assignment Dec 14, 2021

dominiqueclarke self-assigned this Dec 15, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Uptime] Users can't save ML Job alerts and see error when they don't have write access to uptime #118404

[Uptime] Users can't save ML Job alerts and see error when they don't have write access to uptime #118404

lucasfcosta commented Nov 11, 2021 •

edited

Loading

elasticmachine commented Nov 11, 2021

lucasfcosta commented Dec 1, 2021 •

edited

Loading

dominiqueclarke commented Dec 16, 2021

[Uptime] Users can't save ML Job alerts and see error when they don't have write access to uptime #118404

[Uptime] Users can't save ML Job alerts and see error when they don't have write access to uptime #118404

Comments

lucasfcosta commented Nov 11, 2021 • edited Loading

elasticmachine commented Nov 11, 2021

lucasfcosta commented Dec 1, 2021 • edited Loading

dominiqueclarke commented Dec 16, 2021

lucasfcosta commented Nov 11, 2021 •

edited

Loading

lucasfcosta commented Dec 1, 2021 •

edited

Loading