Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Assistant tests consider ES version in tests #123063

Closed
mshustov opened this issue Jan 14, 2022 · 6 comments
Closed

Upgrade Assistant tests consider ES version in tests #123063

mshustov opened this issue Jan 14, 2022 · 6 comments
Assignees
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@mshustov
Copy link
Contributor

Describe the feature: We are working on enabling a test scenario when a Kibana instance v7.last is running against Elasticsearch v8.x. This scenario is short-lived and mostly it's needed for the rolling-upgrade cases.
As expected, some UA tests relying on API removed from v8.0 started failing. These failures can cloak real problems, so we need to make sure that UA tests consider the ES version it communicates with:

  • it's fine to use deprecated API when running against ES v7.x
  • UA shouldn't use deprecated API when running against ES v8.x
@mshustov mshustov added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Upgrade Assistant labels Jan 14, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/platform-deployment-management (Team:Deployment Management)

@cjcenizal
Copy link
Contributor

In #112907 we introduced a UX that prevents users from interacting with the UI during a rolling upgrade. We also wrap each API endpoint in a guard to prevent calling any ES APIs if there's a rolling upgrade.

We have UI tests to verify the UI change, but I think we could also add API integration tests for each endpoint to verify the API guard.

@cjcenizal
Copy link
Contributor

@mshustov What's the priority of this work? Are you actively working on enabling a test scenario when a Kibana instance v7.last is running against Elasticsearch v8.x? If so could you cross-link to any relevant issues or PRs?

@alisonelizabeth
Copy link
Contributor

I have a draft PR up that adds API integration tests based on the discussion in #123063 (comment).

I believe @tylersmalley is working on enabling CI to run Kibana 7.last against Elastic 8.x.

@tylersmalley
Copy link
Contributor

@alisonelizabeth, you can now temporarily test a 7.17 PR against 8.1 by adding the following to .buildkite/scripts/common/env.sh:

export ES_SNAPSHOT_MANIFEST="https://storage.googleapis.com/kibana-ci-es-snapshots-daily/8.1.1/manifest-latest-verified.json" 

(change the version in the manifest URL if needed)

The same thing happens on our nightly forward compatibility tests (which we just resolved a failure with) for 8.0 and 8.1.

Reach out if you have any questions.

@alisonelizabeth
Copy link
Contributor

Fixed via #126524

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Upgrade Assistant Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants