Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[data views] type cleanup [IIndexPattern, DataViewBase] => DataView and [IFieldType, DataViewFieldBase] => DataViewField #129433

Open
mattkime opened this issue Apr 5, 2022 · 2 comments
Open

[data views] type cleanup [IIndexPattern, DataViewBase] => DataView and [IFieldType, DataViewFieldBase] => DataViewField #129433

mattkime opened this issue Apr 5, 2022 · 2 comments
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@mattkime
Copy link
Contributor

mattkime commented Apr 5, 2022

  1. Move DataView and DataViewField interfaces to package
  2. Replace DataViewBase and DataViewFieldBase with non base versions
  3. Replace IIndexPattern and IFieldType with DataView and DataViewField
    • This may require changes by other teams in their apps
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppServicesSv labels Apr 5, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesSv)

@exalate-issue-sync exalate-issue-sync bot added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:medium Medium Level of Effort labels Apr 5, 2022
@mattkime mattkime mentioned this issue Apr 8, 2022
Closed
@kertal kertal added bug Fixes for quality problems that affect the customer experience Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed bug Fixes for quality problems that affect the customer experience labels Nov 18, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

@mattkime mattkime added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. and removed impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:medium Medium Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mattkime @kertal @elasticmachine