Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index patterns - simplify relationship between IndexPattern class, IIndexPattern, and IndexPatternSpec #78378

Closed
mattkime opened this issue Sep 24, 2020 · 2 comments
Closed

Index patterns - simplify relationship between IndexPattern class, IIndexPattern, and IndexPatternSpec #78378

mattkime opened this issue Sep 24, 2020 · 2 comments
Assignees
@mattkime
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@mattkime
Copy link
Contributor

While the main api methods IndexPatterns has been refactored, the object structure needs a similar simplification which mainly affects functions that take IndexPattern instances as arguments. IIndexPattern provides a means of accepting either an IndexPattern instance or a plain javascript object. It would be better to use the IndexPatternSpec more widely since its easy to configure and can be generated by an IndexPattern instance.
@mattkime mattkime added Feature:Data Views Data Views code and UI - index patterns before 8.0 Team:AppArch labels Sep 24, 2020
@mattkime mattkime self-assigned this Sep 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

This was referenced Sep 24, 2020
Closed
Closed
Closed
@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Jun 21, 2021
@mattkime
Copy link
Contributor Author

mattkime commented Apr 8, 2022

closing in favor of #129433

@mattkime mattkime closed this as completed Apr 8, 2022
@exalate-issue-sync exalate-issue-sync bot reopened this Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattkime mattkime

Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattkime @elasticmachine