Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard/Reporting] Control should (probably) not be visible on print-optimized reports #133182

Closed
jloleysens opened this issue May 31, 2022 · 3 comments · Fixed by #133446
Closed
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@jloleysens
Copy link
Contributor

Kibana version: assuming since controls were introduced and this PR was merged #130546

Describe the bug:

Steps to reproduce:

  1. Create a new dashboard
  2. Adding a control
  3. Request a print-optimized PDF from the "Share" menu

Expected behavior:

Controls should probably not be visible on the print optimized report. Or they should be marked as visualisations so they can be positioned properly? I think if we go with the former fix we can always return to this in future.

Screenshots (if relevant):

Screenshot 2022-05-31 at 11 11 00

Any additional context:

  • This is only an issue for the print-optimized reports, while this does not "break" anything this can be considered a visual bug since the lower visualisation (there should be two per page) is moved on to the next page.
@jloleysens jloleysens added bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels May 31, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@ThomThomson
Copy link
Contributor

In print-optimized reports, do we have any method at all for displaying the filter / query context that created the report? If so, the controls could render as an extension of that instead of being hidden.

If not, I think they should be totally hidden in the print optimized view.

@jloleysens
Copy link
Contributor Author

Hey @ThomThomson ! There is no existing way to do that, but I'm certain it could be done :)

I think the best fix for now would be to hide the controls when generating a report then, as part of an enhancement add the capability to render information about queries / filters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants