-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Controls] Hide in Print Mode #133446
[Controls] Hide in Print Mode #133446
Conversation
Pinging @elastic/kibana-presentation (Team:Presentation) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally + code review.
Code changes are simple, but noticed some strange behaviour around basic PDF/PNG reports (not print optimized) for dashboards with controls - will file a separate issue for this.
Otherwise, print optimized PDFs work great thanks to this PR 👍
Edit: I filed the issue above - #133547
(cherry picked from commit eadedd1)
Summary
Fixes #133182
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers