Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Align UI Shipper options with shipper configs #147613

Closed
6 tasks done
criamico opened this issue Dec 15, 2022 · 1 comment · Fixed by #151341
Closed
6 tasks done

[Fleet] Align UI Shipper options with shipper configs #147613

criamico opened this issue Dec 15, 2022 · 1 comment · Fixed by #151341
Assignees
@criamico
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@criamico
Copy link
Contributor

criamico commented Dec 15, 2022 •
edited by jen-huang
Loading

Follow up of #141508

With #145755, Fleet got a new section to manage the Elastic Shipper options, however the Shipper itself was not yet finalised at the time, so some adjustments are needed to align Fleet with those configurations.
@criamico criamico added Team:Fleet Team label for Observability Data Collection Fleet team v8.7.0 labels Dec 15, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

This was referenced Dec 15, 2022
Closed
Merged
@jlind23 jlind23 mentioned this issue Jan 18, 2023
Closed
@jen-huang jen-huang removed the v8.7.0 label Jan 26, 2023
@criamico criamico self-assigned this Feb 13, 2023
@criamico criamico mentioned this issue Feb 15, 2023
Merged
2 tasks
criamico added a commit that referenced this issue Feb 16, 2023
@criamico @kibanamachine
[Fleet] Hide from UI some shipper options (#151341)
b94c777 
Closes #147613 
Closes #147613

## Summary
Follow up of #145755

Introduce a feature flag (`showExperimentalShipperOptions`) to hide from
the UI the shipper options that are still not ready to be shown to the
user. The only available parameters for now should be the following, as
per
[comment](elastic/ingest-dev#1512 (comment)):

- Mem queue
- Max batch size
- Queue flush timeout

### Testing steps
- Add a new output and in the yaml editor add one of the following and
save it;

```
shipper: {}
```
or

```
shipper:
  enabled: true
```

- Edit the output, the shipper section should appear under "advanced
options"

<img width="742" alt="Screenshot 2023-02-15 at 16 30 01"
src="https://user-images.githubusercontent.com/16084106/219096849-cf6041c5-654c-404d-b8de-7fdc13cec2f4.png">

- Generated full agent policy:
<img width="762" alt="Screenshot 2023-02-16 at 15 05 20"
src="https://user-images.githubusercontent.com/16084106/219386500-6b791c33-afee-4458-af5e-3ffb381baf8c.png">


There are more parameters visible, but they're set to `null`

### Checklist

- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

---------

Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
@criamico criamico mentioned this issue Mar 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@criamico criamico

Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Hide from UI some shipper options criamico/kibana
3 participants
@jen-huang @elasticmachine @criamico