Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/dashboard/group3/drilldowns/dashboard_to_dashboard_drilldown·ts - dashboard drilldowns Dashboard to dashboard drilldown Create & use drilldowns test dashboard to dashboard drilldown with controls creates filter pills representing controls selections

[kibanamachine]

A test failed on a tracked branch

Error: expected false to equal true
    at Assertion.assert (expect.js:100:11)
    at Assertion.apply (expect.js:227:8)
    at Assertion.be (expect.js:69:22)
    at Context.<anonymous> (dashboard_to_dashboard_drilldown.ts:344:69)
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at Object.apply (wrap_function.js:73:16)

First failure: CI Build - main

[kibanamachine]

New failure: CI Build - main

[jbudz]

/skip

[elasticmachine]

Pinging @elastic/kibana-presentation (Team:Presentation)

[kibanamachine]

Skipped

main: a9af9e7

[ThomThomson]

This is really strange - it's looking for the filter pills from the control selections, but they aren't there at all. I wonder if this is some sort of rare race condition. The lines it fails on are:

expect(await filterBar.hasFilter('geo.src', 'CN, US')).to.be(true);
expect(await filterBar.hasFilter('bytes', '1,000 to 15,000')).to.be(true);

It's only got the filter taken from the drilldown itself:

[Heenawter]

@ThomThomson The problem with these tests is the failure could come from two places: (1) the selections made in the controls from the source dashboard could have failed somehow or (2) the destination dashboard just didn't receive the selections (due to possibly a race condition, as you mentioned).

I wonder if it would be worth adding extra checks to optionsListPopoverSelectOption and rangeSliderSet<Upper/Lower>Bound to ensure the selections are actually made? Or we could just add some extra checks to the before ('add controls and make selections') to ensure the selections are made before navigating to the destination dashboard.

[ThomThomson]

Very good point / idea! Why don't we modify the selection methods to ensure that the selections actually apply - that way we can at least narrow down which of the two problems we're facing here.