Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Unified Search bar refresh button does not works #156363

Closed
achyutjhunjhunwala opened this issue May 2, 2023 · 1 comment
Closed

[APM] Unified Search bar refresh button does not works #156363

achyutjhunjhunwala opened this issue May 2, 2023 · 1 comment
Assignees
@achyutjhunjhunwala
Labels
8.8 candidate apm:test-plan-regression bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.8.0

Comments

@achyutjhunjhunwala
Copy link
Contributor

achyutjhunjhunwala commented May 2, 2023 •
edited
Loading

Introduced as part of #153842
Kibana version: 8.8

Describe the bug:
When searchbar state is not changed, the Refresh button handler does not refreshes the page.

Steps to reproduce:

  1. Go to Service Overview Page.
  2. Click on the refresh button next to Unified Search Bar.

Expected behavior:

  1. It should refresh the page.

Any additional context:

This happens because we do a history.push on the submit handler which does nothing when the current and next state is same. Hence does not refreshes the page.
@achyutjhunjhunwala achyutjhunjhunwala added bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support apm:test-plan-regression labels May 2, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:APM)

@achyutjhunjhunwala achyutjhunjhunwala self-assigned this May 3, 2023
This was referenced May 12, 2023
Merged
Closed
achyutjhunjhunwala added a commit that referenced this issue May 15, 2023
@achyutjhunjhunwala
[APM]Fix manual refresh and auto refresh issue (#157472)
12dd688 
Fixes - #156363

Depends on - #157468
## Summary

The PR fixes the issues
1. Where when manually Refresh button on the Unified Search Bar is
clicked, the refresh would do nothing.
2. When setting refresh interval and enabling automatic refresh, the
page won't refresh respecting the settings.
3. When refresh interval was set and enabled, now when the whole page
was refreshed, these settings would be lost as these settings were not
originally synced to the URL
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 15, 2023
@achyutjhunjhunwala
[APM]Fix manual refresh and auto refresh issue (elastic#157472)
0f8d1a2 
Fixes - elastic#156363

Depends on - elastic#157468
## Summary

The PR fixes the issues
1. Where when manually Refresh button on the Unified Search Bar is
clicked, the refresh would do nothing.
2. When setting refresh interval and enabling automatic refresh, the
page won't refresh respecting the settings.
3. When refresh interval was set and enabled, now when the whole page
was refreshed, these settings would be lost as these settings were not
originally synced to the URL

(cherry picked from commit 12dd688)
kibanamachine added a commit that referenced this issue May 15, 2023
@kibanamachine @achyutjhunjhunwala
[8.8] [APM]Fix manual refresh and auto refresh issue (#157472) (#157744)
b0a48bd 
# Backport

This will backport the following commits from `main` to `8.8`:
- [[APM]Fix manual refresh and auto refresh issue
(#157472)](#157472)

<!--- Backport version: 8.9.7 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Achyut
Jhunjhunwala","email":"achyut.jhunjhunwala@elastic.co"},"sourceCommit":{"committedDate":"2023-05-15T14:55:49Z","message":"[APM]Fix
manual refresh and auto refresh issue (#157472)\n\nFixes -
#156363 on -
#157468 Summary\r\n\r\nThe
PR fixes the issues\r\n1. Where when manually Refresh button on the
Unified Search Bar is\r\nclicked, the refresh would do nothing.\r\n2.
When setting refresh interval and enabling automatic refresh,
the\r\npage won't refresh respecting the settings.\r\n3. When refresh
interval was set and enabled, now when the whole page\r\nwas refreshed,
these settings would be lost as these settings were not\r\noriginally
synced to the
URL","sha":"12dd68848d0b191ce0d3833ebc262cf075e2c21f","branchLabelMapping":{"^v8.9.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:APM","release_note:skip","v8.8.0","v8.9.0"],"number":157472,"url":"#157472
manual refresh and auto refresh issue (#157472)\n\nFixes -
#156363 on -
#157468 Summary\r\n\r\nThe
PR fixes the issues\r\n1. Where when manually Refresh button on the
Unified Search Bar is\r\nclicked, the refresh would do nothing.\r\n2.
When setting refresh interval and enabling automatic refresh,
the\r\npage won't refresh respecting the settings.\r\n3. When refresh
interval was set and enabled, now when the whole page\r\nwas refreshed,
these settings would be lost as these settings were not\r\noriginally
synced to the
URL","sha":"12dd68848d0b191ce0d3833ebc262cf075e2c21f"}},"sourceBranch":"main","suggestedTargetBranches":["8.8"],"targetPullRequestStates":[{"branch":"8.8","label":"v8.8.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v8.9.0","labelRegex":"^v8.9.0$","isSourceBranch":true,"state":"MERGED","url":"#157472
manual refresh and auto refresh issue (#157472)\n\nFixes -
#156363 on -
#157468 Summary\r\n\r\nThe
PR fixes the issues\r\n1. Where when manually Refresh button on the
Unified Search Bar is\r\nclicked, the refresh would do nothing.\r\n2.
When setting refresh interval and enabling automatic refresh,
the\r\npage won't refresh respecting the settings.\r\n3. When refresh
interval was set and enabled, now when the whole page\r\nwas refreshed,
these settings would be lost as these settings were not\r\noriginally
synced to the URL","sha":"12dd68848d0b191ce0d3833ebc262cf075e2c21f"}}]}]
BACKPORT-->

Co-authored-by: Achyut Jhunjhunwala <achyut.jhunjhunwala@elastic.co>
jasonrhodes pushed a commit that referenced this issue May 17, 2023
@achyutjhunjhunwala @jasonrhodes
[APM]Fix manual refresh and auto refresh issue (#157472)
28ab776 
Fixes - #156363

Depends on - #157468
## Summary

The PR fixes the issues
1. Where when manually Refresh button on the Unified Search Bar is
clicked, the refresh would do nothing.
2. When setting refresh interval and enabling automatic refresh, the
page won't refresh respecting the settings.
3. When refresh interval was set and enabled, now when the whole page
was refreshed, these settings would be lost as these settings were not
originally synced to the URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
8.8 candidate apm:test-plan-regression bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v8.8.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gbamparop @achyutjhunjhunwala @elasticmachine